Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine python dependency list and check dependencies in order #9061

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Oct 8, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • no changes or updates in poetry.lock lockfile and locked dependency verions
  • add new dependency group storage for listing library used for storage clients
  • add unit test to check dependencies in alphabet order in each dependency group
  • avoid using the ^ operator in version definition which easily causing unexpected incompatible version problems in updating

image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • add unit test checking dependencies in alphabet order in each dependency group

@bowenliang123 bowenliang123 marked this pull request as ready for review October 8, 2024 03:29
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 8, 2024
@bowenliang123 bowenliang123 changed the title chore: refine python dependency list and check dependencies in alphabet order chore: refine python dependency list and check dependencies in order Oct 8, 2024
@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Oct 8, 2024
@bowenliang123 bowenliang123 force-pushed the refine-pyproject branch 2 times, most recently from 103148d to a5046e6 Compare October 8, 2024 05:06
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 8, 2024
@bowenliang123 bowenliang123 force-pushed the refine-pyproject branch 4 times, most recently from c5b8aed to 3f9f7a8 Compare October 8, 2024 06:17
@bowenliang123
Copy link
Contributor Author

It's ready for review. cc @laipz8200 @crazywoola

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@laipz8200 laipz8200 merged commit 896998e into langgenius:main Oct 8, 2024
6 checks passed
@bowenliang123 bowenliang123 deleted the refine-pyproject branch October 8, 2024 07:11
@bowenliang123
Copy link
Contributor Author

Thanks~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants