Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply ruff E501 line-too-long linter rule #8275

Merged
merged 2 commits into from
Sep 12, 2024
Merged

chore: apply ruff E501 line-too-long linter rule #8275

merged 2 commits into from
Sep 12, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Sep 11, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • check the violation of E501 line-too-long rule by Ruff
  • no behavior changes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@bowenliang123 bowenliang123 changed the title chore: reenable ruff e501 line-too-long linter rule chore: reenable ruff E501 line-too-long linter rule Sep 11, 2024
@bowenliang123 bowenliang123 marked this pull request as ready for review September 11, 2024 23:21
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Sep 11, 2024
@bowenliang123
Copy link
Contributor Author

cc @laipz8200 @crazywoola

@laipz8200 laipz8200 self-requested a review September 12, 2024 04:56
@bowenliang123 bowenliang123 changed the title chore: reenable ruff E501 line-too-long linter rule chore: apply ruff E501 line-too-long linter rule Sep 12, 2024
laipz8200
laipz8200 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@laipz8200 laipz8200 merged commit c69f5b0 into langgenius:main Sep 12, 2024
6 checks passed
@bowenliang123 bowenliang123 deleted the ruff-e501 branch September 12, 2024 06:03
ZhouhaoJiang added a commit that referenced this pull request Sep 12, 2024
@ZhouhaoJiang
Merge branch 'main' into feat/new-login
619eeec 
* main:
  chore: refurbish Python code by applying refurb linter rules (#8296)
  chore: apply ruff E501 line-too-long linter rule (#8275)
  fix(workflow): missing content in the answer node stream output during iterations (#8292)
  chore: cleanup ruff flake8-simplify linter rules (#8286)
  fix: markdown paragraph margin (#8289)
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
@bowenliang123 @laipz8200 @cuiks
chore: apply ruff E501 line-too-long linter rule (langgenius#8275)
30ea426 
Co-authored-by: -LAN- <laipz8200@outlook.com>
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@bowenliang123 @laipz8200 @lau-td
chore: apply ruff E501 line-too-long linter rule (langgenius#8275)
454f9aa 
Co-authored-by: -LAN- <laipz8200@outlook.com>
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@bowenliang123 @laipz8200 @JunXu01
chore: apply ruff E501 line-too-long linter rule (langgenius#8275)
e82c63e 
Co-authored-by: -LAN- <laipz8200@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowenliang123 @laipz8200