-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support png, gif, webp #7947
Conversation
thank @xuzuodong , I will fix it asap |
The implementation for determining animated .webp images looks good to me. Could you also review the other minor issues mentioned above? |
@xuzuodong I did it |
@ZuzooVn Uploading an animated image will raise an error now. 2024-10-08.09.35.41.mov |
@xuzuodong I can not reproduce this issue. Could you please send me that image? |
Here's the webp image: animated-webp-supported.webp.zip Although I don't think there's anything special about this image; the error is clearly caused by accessing 2024-10-11.17.19.25.mov |
Hello can you resolve those comments. |
Co-authored-by: xuanson9699 <84961581+xuanson9699@users.noreply.github.com>
Co-authored-by: xuanson9699 <84961581+xuanson9699@users.noreply.github.com>
Co-authored-by: xuanson9699 <84961581+xuanson9699@users.noreply.github.com>
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
PNg
GIF, WEBP
2024-09-04_06-41-13.mp4
Type of Change