Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/remove python dependencies selector #7494

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

Yeuoly
Copy link
Collaborator

@Yeuoly Yeuoly commented Aug 21, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Selecting python dependencies manually is no longer required due to the update of dify-sandbox

image

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. dependencies Pull requests that update a dependency file 🐍 python labels Aug 21, 2024
@Yeuoly Yeuoly requested review from laipz8200 and takatost August 21, 2024 08:13
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2024
@Yeuoly Yeuoly merged commit 784b11c into main Aug 21, 2024
9 checks passed
@Yeuoly Yeuoly deleted the chore/remove-python-dependencies-selector branch August 21, 2024 08:57
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
@Hanfee
Copy link

Hanfee commented Sep 9, 2024

Why remove list python dependencies funciton?
Now don't know imported module @Yeuoly

@crazywoola
Copy link
Member

crazywoola commented Sep 9, 2024

This is not required anymore. If you add things in the requirements.txt, it should be able to be imported automatically.

@natsu12
Copy link

natsu12 commented Sep 13, 2024

This is not required anymore. If you add things in the requirements.txt, it should be able to be imported automatically.

@crazywoola

image

The previous code node automatically imported the standard library (such as datetime and time), so the user's code did not need to explicitly declare import statements. However, after updating to this version, the code node must explicitly declare import statements, otherwise the user's code will report a "not defined error". In this case, how can the running business code be updated?

idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants