Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pgvector full_text_search #7396

Merged
merged 3 commits into from
Aug 20, 2024
Merged

feat: add pgvector full_text_search #7396

merged 3 commits into from
Aug 20, 2024

Conversation

jasonkang14
Copy link
Contributor

@jasonkang14 jasonkang14 commented Aug 19, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Added Full Text Search on pg_vector according to PSQL Full Text Search. works well with different languages such as English, Korean, and Chinese

Closes #7190

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested locally after changing the VECTOR_STORE configuration in .env to pgvector. Please refer to the screenshot below
Screenshot 2024-08-19 at 4 29 15 PM

** edited **
fixed a bug associated with having a whitespace in query
Screenshot 2024-08-19 at 4 45 25 PM

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. 💪 enhancement New feature or request labels Aug 19, 2024
@jasonkang14 jasonkang14 deleted the feature/pgvector-full-text-search branch August 19, 2024 07:38
@jasonkang14 jasonkang14 reopened this Aug 19, 2024
@crazywoola crazywoola requested a review from JohnJyong August 19, 2024 11:14
@jasonkang14
Copy link
Contributor Author

jasonkang14 commented Aug 19, 2024

I will look at the test code for pg_vector and see how I can fix it and push it again

done!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 20, 2024
@JohnJyong JohnJyong merged commit 0223fc6 into langgenius:main Aug 20, 2024
6 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pg_vector full text search
2 participants