chore: allow download audio/video through HTTP node #7224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
crazywoola
approved these changes
Aug 14, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Aug 16, 2024
* main: (107 commits) Fix: missing default value of type array object in conversation variable modal (#7309) fix: inability-to-add-node-and-change-the-edge (#7303) fix(api/services/app_dsl_service.py): Add conversation variables. (#7304) Feat/7023 dify editor can resize the image (#7296) fix(api/core/app/segments/segments.py): Fix file to markdown. (#7293) feat: support pinning, including, and excluding for Model Providers and Tools (#7283) chore(api): Introduce Ruff Formatter. (#7291) chore(api/core): Improve FileVar's type hint and imports. (#7290) feat: support OPENAI json_schema (#7258) feat: add chatgpt-4o-latest (#7289) feat(api/workflow): Add `Conversation.dialogue_count` (#7275) fix: can not input param value in tool test modal (#7281) Add jp translation for variable aggregator (#7277) fix: #7222 docstrings (#7276) fix ja-JP translation of secret values (#7279) fix: typo in upstage/llm/_position.yaml (#7286) fix: missed rerank_mode when convert to DatasetEntity (#7269) Fix SQL parser Error in MyScale vdb. (#7255) chore: allow download audio/video through HTTP node (#7224) Fix: support hide env & conversation var in prompt editor (#7256) ...
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
At present, we only allow images download through HTTP node. I don't know why, I think we should allow more types to download. The code here limit image/audio/video in content-type can get the mimetype and can be downloaded.
Type of Change
Testing Instructions
test url
https://cdn.pixabay.com/download/audio/2023/08/05/audio_145e6bad08.mp3?filename=usb-connect-160911.mp3