Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n/ja-JP/dataset-documents.ts "embeddedSpend" value. #7124

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

k-brahma
Copy link
Contributor

@k-brahma k-brahma commented Aug 9, 2024

Update i18n/ja-JP/dataset-documents.ts "embeddedSpend" value.

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR updates the Japanese translation for the "embeddedSpend" field in the dataset-documents.ts file. The translation has been changed from "埋め込み時間" to "埋め込みコスト" to more accurately reflect the meaning of "Embedded spend".

This change is related to the issue of i18n translations not being reflected in the Docker environment, which is being tracked separately in issue #7123. While this PR addresses the translation update itself, the visibility of this change in the Docker environment is still under investigation.

Fixes #(issue number for the translation update, if one exists)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

To verify this change:

  1. Navigate to the web/i18n/ja-JP/dataset-documents.ts file.
  2. Confirm that the "embeddedSpend" field is now translated as "埋め込みコスト".
  3. Run the following commands to build the project:
    cd /path/to/dify/
    npm ci
    cd web/
    npm ci
    npm run build
    
  4. Check the built files to ensure the change is included:
    cd /path/to/dify/web/.next/server
    grep -r "埋め込みコスト" .
    
  5. Launch the application and navigate to the relevant UI section to visually confirm the change.

Note: As mentioned in issue #7123, there may be discrepancies between the built files and the Docker environment. However, since npm build succeeds and the updated string can be found in /path/to/dify/web/.next/server, I believe this PR sufficiently addresses the .ts file syntax update. The Docker-related discrepancy would be investigated separately and should not block this translation update.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. labels Aug 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@crazywoola crazywoola merged commit f4591f9 into langgenius:main Aug 9, 2024
3 checks passed
@k-brahma k-brahma deleted the fix/dataset-documents branch August 9, 2024 01:30
ZhouhaoJiang added a commit that referenced this pull request Aug 9, 2024
…deploy/dev

* 'deploy/dev' of https://github.com/langgenius/dify: (42 commits)
  fix: account delete function
  chore: improve Vietnamese (vi-VN) translations (#7127)
  Update i18n/ja-JP/dataset-documents.ts "embeddedSpend" value. (#7124)
  update stepfun model (#7118)
  feat: wenxin add yi-34b-chat (#7117)
  fix annotation reply is null (#7103)
  feat: Postgres max connections (#7067)
  feat: add zhipu embedding-3 (#7100)
  feat: add text-embedding functon and LLM models to Siliconflow (#7090)
  extract docx filter comment element (#7092)
  fix: refine the tooltip component
  fix: only update&request sso settings when enabled
  fix: workflow search blocks (#7097)
  feat: app icon enhancements (#7095)
  workflow logs support workflow run id filter (#6833)
  fix: set enable_web_sso_switch_component default value to false
  feat: add a builtin tool to support regex extraction. (#7081) (#7087)
  add nltk punkt resource (#7063)
  Feat/add 360-zhinao provider (#7069)
  feat: Poetry requests timeout (#7086)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants