Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support glm-4-long #7070

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

ox01024
Copy link
Contributor

@ox01024 ox01024 commented Aug 7, 2024

Checklist:

Important

[> Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue close Add support for glm-4-long to zhipuai. #6986
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods](url)

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Close #6986

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ⚙️ feat:model-runtime labels Aug 7, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This context size should be defined in:

model_properties:
  mode: chat
  context_size: 16384

…yaml


token size

Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
@ox01024 ox01024 force-pushed the feat-support-glm-4-long branch from 508ce57 to 35e3072 Compare August 8, 2024 01:16
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2024
@crazywoola crazywoola merged commit 5e2fa13 into langgenius:main Aug 8, 2024
6 checks passed
@ox01024 ox01024 deleted the feat-support-glm-4-long branch August 8, 2024 03:11
@ox01024 ox01024 mentioned this pull request Aug 13, 2024
5 tasks
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for glm-4-long to zhipuai.
2 participants