Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The permissions issue of the editor role accessing some backend … #6945

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

liuzhenghua
Copy link
Contributor

…APIs

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fix the permissions issue of the editor role accessing some backend.
Here are the scenarios that are affected:

  1. Knowledge -> File -> Add chunk.
  2. Studio -> App -> Logs
  3. Studio -> App -> Annotations

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Create an account with the EDITOR role and access the pages described above, you will get an insufficient privilege error."

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Aug 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 5, 2024
@crazywoola crazywoola merged commit ef616c6 into langgenius:main Aug 5, 2024
6 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
langgenius#6945)

Co-authored-by: liuzhenghua-jk <liuzhenghua-jk@360shuke.com>
ZhouhaoJiang added a commit that referenced this pull request Aug 6, 2024
* refs/heads/feat/web-app-sso:
  feat: web sso app
  Fixed a bug where permission was clearly displaye… (#6934)
  fix: The permissions issue of the editor role accessing some backend … (#6945)
  Fix: tag & settings modal in dataset card in Firefox (#6953)
  fix: ensure db migration in docker entry script running with `upgrade-db` command for proper locking (#6946)
  chore: fix markdown format and one typo (#6939)
  fix: restore xinference secret field (#6941)
  Fix increase_usage of total_price in agent_runner (#6688)
  fix: import workflow errors (#6937)
  Workflow TTS playback node filtering issue. (#6877)
  compatible xinference reranker server (#6927)
  fix: workflow trace user_id error (#6932)
  fix: sending app trace data to other app trace provider (#6931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants