Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/nodes): Fallback to get_any in some nodes that use object or array. #6566

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 23, 2024
@laipz8200 laipz8200 requested a review from takatost July 23, 2024 07:36
@dosubot dosubot bot added the 🌊 feat:workflow Workflow related stuff. label Jul 23, 2024
takatost
takatost previously approved these changes Jul 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 23, 2024
@laipz8200 laipz8200 force-pushed the fix/fallback-to-get-any-in-some-nodes branch from 39036fd to f8c7aba Compare July 23, 2024 07:48
@takatost takatost merged commit cfc4080 into main Jul 23, 2024
8 checks passed
@takatost takatost deleted the fix/fallback-to-get-any-in-some-nodes branch July 23, 2024 07:51
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Jul 27, 2024
* commit '49729647ea0bed4f78e6970b36b105da6aaec614': (108 commits)
  bump to 0.6.15 (langgenius#6592)
  fix(variables): NoneVariable should inherit from NoneSegment. (langgenius#6584)
  feat: update prompt generate (langgenius#6516)
  chore: enchance auto generate prompt (langgenius#6564)
  fix(segments): Support NoneType. (langgenius#6581)
  fix audio not working during development due to react's useEffect wil be triggered twice (langgenius#6126)
  chore: layout UI upgrade (langgenius#6577)
  fix(api/core/workflow/nodes/llm/llm_node.py): Fix LLM Node error. (langgenius#6576)
  fix: tool params not work as expected when develop a tool (langgenius#6550)
  fix: name 'current_app' is not defined in recommended_app_service (langgenius#6574)
  feat: add tencent asr (langgenius#6091)
  fix: extract only `like` feedback to caculate User Satisfaction (langgenius#6553)
  feat(variables): Support `to_object`. (langgenius#6572)
  fix(api/nodes): Fallback to `get_any` in some nodes that use object or array. (langgenius#6566)
  fix: fetch context error in llm node (langgenius#6562)
  fix the issue of MILVUS_DATABASE has no effect. (langgenius#6424)
  Add search by full text when using Oracle23ai as vector DB (langgenius#6559)
  fix: escape double quotation marks in the vector DB search query (langgenius#6506)
  feat: add Mingdao HAP tool, implemented read and maintain HAP application worksheet data. (langgenius#6257)
  fix: chat flow chat with annotation or moderation but answer empty (langgenius#6202)
  ...

# Conflicts:
#	api/core/model_runtime/model_providers/openai/llm/gpt-4o-mini-2024-07-18.yaml
#	api/core/model_runtime/model_providers/openai/llm/gpt-4o-mini.yaml
#	api/core/tools/tool_file_manager.py
#	api/core/workflow/nodes/tool/tool_node.py
#	api/poetry.lock
#	web/yarn.lock
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants