-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct gpt-4o-mini max token #6472
Merged
crazywoola
merged 4 commits into
langgenius:main
from
sinomoe:fix/gpt-4o-mini-max-token
Jul 19, 2024
Merged
fix: correct gpt-4o-mini max token #6472
crazywoola
merged 4 commits into
langgenius:main
from
sinomoe:fix/gpt-4o-mini-max-token
Jul 19, 2024
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Jul 19, 2024
crazywoola
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this issue #6474
api/core/model_runtime/model_providers/openai/llm/gpt-4o-mini-2024-07-18.yaml
Outdated
Show resolved
Hide resolved
api/core/model_runtime/model_providers/openai/llm/gpt-4o-mini.yaml
Outdated
Show resolved
Hide resolved
api/core/model_runtime/model_providers/openrouter/llm/gpt-4o-mini.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
crazywoola
approved these changes
Jul 19, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Jul 22, 2024
* refs/heads/main: (62 commits) fix: extract tool calls correctly while arguments is empty (#6503) clean vector collection redis cache (#6494) refactor(api): switch to dify_config in controllers/console (#6485) update delete embeddings by id (#6489) update clean embedding cache query logic (#6483) Fix/extra table tracing app config (#6487) feat(tool): getimg.ai integration (#6260) fix: next suggest question logic problem (#6451) fix: build error (#6480) fix: correct gpt-4o-mini max token (#6472) Update CONTRIBUTING_CN "安装常见问题解答" link. (#6470) Update CONTRIBUTING "installation FAQ" link. (#6471) Update CONTRIBUTING_JA "installation FAQ" link. (#6469) chore: some components upgrage to new ui (#6468) fix wrong method using (#6459) feat: support gpt-4o-mini for openrouter provider (#6447) update ernie models (#6454) chore: make text generation timeout duration configurable (#6450) refactor(myscale):Set the default value of the myscale vector db in DifyConfig. (#6441) [EMERGENCY] Fix Anthropic header issue (#6445) ...
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Aug 6, 2024
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
According to https://openrouter.ai/models/openai/gpt-4o-mini, the max_tokens for the GPT-4o-mini is 16k.
Fixes #6474
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration