-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/delete file when clean document #5882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
💪 enhancement
New feature or request
labels
Jul 2, 2024
crazywoola
previously requested changes
Jul 2, 2024
takatost
requested changes
Jul 4, 2024
crazywoola
approved these changes
Jul 15, 2024
This was referenced Jul 17, 2024
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Jul 22, 2024
* commit 'eabfd84ceb704f8057b4f499578e24c2516250c4': (147 commits) bump to 0.6.14 (langgenius#6294) Feat/delete file when clean document (langgenius#5882) fix: zhipuai validate error when user's api key not support for chatglm_turbo in issue langgenius#6289 (langgenius#6290) fix: validateColorHex: cannot read properties of undefined (reading 'length') (langgenius#6242) 6282 i18n add support for Italian (langgenius#6288) Update bedrock.yaml (langgenius#6281) feat(frontend): workflow import dsl from url (langgenius#6286) feat(backend): support import DSL from URL (langgenius#6287) Update model provider configuration for Triton Inference Server and X… (langgenius#6274) fix: custom tool input number fail (langgenius#6200) Feat/add zhipu CogView 3 tool (langgenius#6210) Fix mermaid render (langgenius#6088) fix: markdown proc will remove image (langgenius#5855) fix: remove the maximum length limit of "paragraph" variable (langgenius#6234) Update ernie_bot.py (langgenius#6236) fix: model-provider-card-style (langgenius#6246) refactor(api): switch to dify_config with Pydantic in controllers and schedule (langgenius#6237) Fix/firecrawl parameters issue (langgenius#6213) refactor(services/tasks): Swtich to dify_config witch Pydantic (langgenius#6203) fix: differentiate prompts fields based on function_calling_type (langgenius#5880) ... # Conflicts: # .github/workflows/build-push.yml # api/configs/app_config.py # api/configs/feature/__init__.py # api/poetry.lock # web/app/components/app/configuration/config-var/config-modal/index.tsx # web/yarn.lock
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Jul 22, 2024
* commit 'eabfd84ceb704f8057b4f499578e24c2516250c4': (147 commits) bump to 0.6.14 (langgenius#6294) Feat/delete file when clean document (langgenius#5882) fix: zhipuai validate error when user's api key not support for chatglm_turbo in issue langgenius#6289 (langgenius#6290) fix: validateColorHex: cannot read properties of undefined (reading 'length') (langgenius#6242) 6282 i18n add support for Italian (langgenius#6288) Update bedrock.yaml (langgenius#6281) feat(frontend): workflow import dsl from url (langgenius#6286) feat(backend): support import DSL from URL (langgenius#6287) Update model provider configuration for Triton Inference Server and X… (langgenius#6274) fix: custom tool input number fail (langgenius#6200) Feat/add zhipu CogView 3 tool (langgenius#6210) Fix mermaid render (langgenius#6088) fix: markdown proc will remove image (langgenius#5855) fix: remove the maximum length limit of "paragraph" variable (langgenius#6234) Update ernie_bot.py (langgenius#6236) fix: model-provider-card-style (langgenius#6246) refactor(api): switch to dify_config with Pydantic in controllers and schedule (langgenius#6237) Fix/firecrawl parameters issue (langgenius#6213) refactor(services/tasks): Swtich to dify_config witch Pydantic (langgenius#6203) fix: differentiate prompts fields based on function_calling_type (langgenius#5880) ... # Conflicts: # .github/workflows/build-push.yml # api/configs/app_config.py # api/configs/feature/__init__.py # api/poetry.lock # web/app/components/app/configuration/config-var/config-modal/index.tsx # web/yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
delete file when document or dataset cleaned
Fixes #5220
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes