Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app config does not use empty string in the env #5741

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

takatost
Copy link
Collaborator

Description

fix: app config does not use empty string in the env

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual test

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐍 python 🐞 bug Something isn't working labels Jun 29, 2024
@takatost takatost merged commit d56cedf into main Jun 29, 2024
8 checks passed
@takatost takatost deleted the fix/env-not-using-empty-str branch June 29, 2024 09:15
ZhouhaoJiang added a commit that referenced this pull request Jun 30, 2024
* refs/heads/main: (29 commits)
  chore: remove port expose in docker compose (#5754)
  fix: langsmith message_trace end_user_data session_id error (#5759)
  fix: workflow trace none type error (#5758)
  fix: missing process data in parameter extractor (#5755)
  Docs/add docker dotenv notes (#5750)
  fix: slow sql of ops tracing (#5749)
  Update docker-compose.yaml (#5745)
  bump to 0.6.12-fix1 (#5743)
  fix: env SMTP_PORT is empty caused err when launching (#5742)
  fix: app config does not use empty string in the env (#5741)
  fix: couldn't log in or resetup after a failed setup (#5739)
  chore: support both $$ and $ latex format (#5723)
  Rename README to README.md (#5727)
  Chore/set entrypoint scripts permissions (#5726)
  add README for new docker/ directory (#5724)
  bump to 0.6.12 (#5712)
  Ignore new middleware.env docker file (#5715)
  fix: _convert_prompt_message_to_dict parameters err (#5716)
  fix: fix-app-site-missing command (#5714)
  feat: add fix-app-site-missing command (#5711)
  ...
ZhouhaoJiang added a commit that referenced this pull request Jul 1, 2024
* refs/heads/feat/knowledge-admin-role: (25 commits)
  feat: dataset operator permission
  feat: patch dataset when not partial_member_list refresh datasetp permission
  chore: remove port expose in docker compose (#5754)
  fix: langsmith message_trace end_user_data session_id error (#5759)
  fix: workflow trace none type error (#5758)
  fix: missing process data in parameter extractor (#5755)
  Docs/add docker dotenv notes (#5750)
  fix: slow sql of ops tracing (#5749)
  Update docker-compose.yaml (#5745)
  bump to 0.6.12-fix1 (#5743)
  fix: env SMTP_PORT is empty caused err when launching (#5742)
  fix: app config does not use empty string in the env (#5741)
  fix: couldn't log in or resetup after a failed setup (#5739)
  chore: support both $$ and $ latex format (#5723)
  Rename README to README.md (#5727)
  Chore/set entrypoint scripts permissions (#5726)
  add README for new docker/ directory (#5724)
  bump to 0.6.12 (#5712)
  Ignore new middleware.env docker file (#5715)
  fix: _convert_prompt_message_to_dict parameters err (#5716)
  ...

# Conflicts:
#	api/commands.py
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Jul 1, 2024
* commit '8fd75e6965a33930967a44a03a1b8640095d6f4a':
  bump to 0.6.12-fix1 (langgenius#5743)
  fix: env SMTP_PORT is empty caused err when launching (langgenius#5742)
  fix: app config does not use empty string in the env (langgenius#5741)
  fix: couldn't log in or resetup after a failed setup (langgenius#5739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant