fix: HTTP request header is overwritten when user set Content-Type #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
Yeuoly
requested changes
Jun 26, 2024
|
Nice fixing~ |
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 28, 2024
* refs/heads/main: (45 commits) fix: do not remove (#5682) Feature/add qwen llm (#5659) Fix docker command (#5681) feature: Add presence_penalty and frequency_penalty parameters to the … (#5637) Feat/fix ops trace (#5672) feat: xxo enhancement. (#5671) chore: rearrange python dependencies in groups (#5603) chore: delete unused resource (#5667) fix: knowledge retrieval score threshold setting (#5658) feat: add jina new pre-defined rerankers, include: jina-reranker-v2 (#5657) fix: tool call message role according to credentials (#5625) fix: HTTP request header is overwritten when user set Content-Type (#5628) chore: apply flake8-comprehensions Ruff rules to improve collection comprehensions (#5652) fix(api): language list (#5649) fix(api/configs): Ignore empty environment variables when loading config. (#5647) fix: type error in config (#5643) fix: remove obsoleted 'version' elements in compose files (#5553) chore: add a secondary confirmation dialog when the user delete the tool (#5634) fix: ro-RO is not a valid language (#5635) FR: #4048 - Add color customization to the chatbot (#4885) ... # Conflicts: # api/config.py # web/app/components/datasets/settings/form/index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5611
If the user explicity sets the
Content-Typefield, we should not overwrite it.Type of Change
How Has This Been Tested?
test locally
Suggested Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsoptionalI have made corresponding changes to the documentationoptionalI have added tests that prove my fix is effective or that my feature worksoptionalNew and existing unit tests pass locally with my changes