-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DuckDuckGo image search tool error #5606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
🐞 bug
Something isn't working
💪 enhancement
New feature or request
labels
Jun 26, 2024
laipz8200
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe we should open a new issue to make our FileVar.url
more readable.
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Jun 26, 2024
* commit '8d9a45908397b3f3c0d56e86160bb97b5611b79b': (240 commits) fix: remove obsoleted 'version' elements in compose files (langgenius#5553) chore: add a secondary confirmation dialog when the user delete the tool (langgenius#5634) fix: ro-RO is not a valid language (langgenius#5635) FR: langgenius#4048 - Add color customization to the chatbot (langgenius#4885) feat: tracing fe (langgenius#5487) feat: add ops trace (langgenius#5483) chore: cleanup test_delete_by_document_id method in opensearch vdb test (langgenius#5619) chore(pyproject.toml): Add Ruff formatter config. (langgenius#5627) Fix link to documentation of nodes (langgenius#5623) feat: undo/redo for workflow editor (langgenius#3927) fix: populate app configs to system environment variables (langgenius#5590) fix: DuckDuckGo image search tool error (langgenius#5606) delete the deprecated method (langgenius#5612) fix: context icon in chat (langgenius#5604) fix: Modify the incorrect configuration name for Google storage (langgenius#5595) feat: update issue template (langgenius#5592) chore: fix typo in config descriptions (langgenius#5585) fix: add support for FILE type in ToolParameterConverter (langgenius#5578) Fix/single run panel show parent scrollbar (langgenius#5574) refactor: extract cors configs into dify config and cleanup the config class (langgenius#5507) ... # Conflicts: # .github/workflows/build-push.yml # api/Dockerfile # api/core/helper/code_executor/code_executor.py # api/requirements.txt
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Jun 26, 2024
* commit '17d2f0bb0d3c7618ed59968613175d2344fcbdc1': (145 commits) fix(api/configs): Ignore empty environment variables when loading config. (langgenius#5647) fix: type error in config (langgenius#5643) fix: remove obsoleted 'version' elements in compose files (langgenius#5553) chore: add a secondary confirmation dialog when the user delete the tool (langgenius#5634) fix: ro-RO is not a valid language (langgenius#5635) FR: langgenius#4048 - Add color customization to the chatbot (langgenius#4885) feat: tracing fe (langgenius#5487) feat: add ops trace (langgenius#5483) chore: cleanup test_delete_by_document_id method in opensearch vdb test (langgenius#5619) chore(pyproject.toml): Add Ruff formatter config. (langgenius#5627) Fix link to documentation of nodes (langgenius#5623) feat: undo/redo for workflow editor (langgenius#3927) fix: populate app configs to system environment variables (langgenius#5590) fix: DuckDuckGo image search tool error (langgenius#5606) delete the deprecated method (langgenius#5612) fix: context icon in chat (langgenius#5604) fix: Modify the incorrect configuration name for Google storage (langgenius#5595) feat: update issue template (langgenius#5592) chore: fix typo in config descriptions (langgenius#5585) fix: add support for FILE type in ToolParameterConverter (langgenius#5578) ... # Conflicts: # .github/workflows/build-push.yml # api/Dockerfile # api/requirements.txt
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 27, 2024
* refs/heads/feat/cleaning_ops_trace: (23 commits) feat: update migrate file fix: generate name trace info error feat: undo/redo for workflow editor (#3927) fix: populate app configs to system environment variables (#5590) fix: DuckDuckGo image search tool error (#5606) delete the deprecated method (#5612) feat: update langfuse trace structure fix: context icon in chat (#5604) fix: Modify the incorrect configuration name for Google storage (#5595) feat: update issue template (#5592) feat: update workflow trace chore: fix typo in config descriptions (#5585) optimize feat: optimize file_list fix fix _invoke_error_mapping of tongyi tts optimize error msg feat: update suggested question trace manager fix: add support for FILE type in ToolParameterConverter (#5578) Fix/single run panel show parent scrollbar (#5574) ... # Conflicts: # api/controllers/console/datasets/error.py # api/services/workflow_service.py # web/i18n/en-US/workflow.ts # web/i18n/zh-Hans/workflow.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 bug
Something isn't working
💪 enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remote_url
field in the files response to avoid affect others.Type of Change
How Has This Been Tested?
I test it locally.
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes