Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support importing and overwriting workflow DSL #5511

Merged
merged 7 commits into from
Jun 25, 2024
Merged

feat: support importing and overwriting workflow DSL #5511

merged 7 commits into from
Jun 25, 2024

Conversation

takatost
Copy link
Collaborator

Description

feat: support importing and overwriting workflow DSL

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual test

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@zxhlyh zxhlyh requested a review from JzoNgKVO June 25, 2024 06:35
@takatost takatost marked this pull request as ready for review June 25, 2024 07:15
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 25, 2024
@takatost takatost removed the request for review from JzoNgKVO June 25, 2024 07:15
@dosubot dosubot bot added the 🌊 feat:workflow Workflow related stuff. label Jun 25, 2024
@zxhlyh zxhlyh requested a review from JzoNgKVO June 25, 2024 07:16
JzoNgKVO
JzoNgKVO previously approved these changes Jun 25, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2024
@zxhlyh zxhlyh requested a review from JzoNgKVO June 25, 2024 07:45
@zxhlyh zxhlyh merged commit ec1d3dd into main Jun 25, 2024
8 checks passed
@zxhlyh zxhlyh deleted the feat/workflow-import-support branch June 25, 2024 07:46
@takatost takatost mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JzoNgKVO JzoNgKVO JzoNgKVO approved these changes

Assignees

@takatost takatost

@zxhlyh zxhlyh

Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takatost @JzoNgKVO @zxhlyh