Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tools): Add Serply Web/Job/Scholar/News Search tool for more options #5186

Merged
merged 11 commits into from
Jun 15, 2024

Conversation

googio
Copy link
Contributor

@googio googio commented Jun 14, 2024

Description

Adding additional tools for searching the web. It supports more options such as country, language. Also adds searching scholar, jobs, and news.

Fixes #5121

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Get free Serply.io account and grab API Key.
  2. Start Dify locally
  3. Set the API Key in WebSearch tool
    image
    image
    image
  4. Add the tools to be used with agents
    image
  5. Verified that the tool are being used

image

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@googio googio changed the title Adding Serply Web/Job/Scholar/News Search tool for more options feat(Tools): Add Serply Web/Job/Scholar/News Search tool for more options Jun 14, 2024
@googio googio marked this pull request as ready for review June 14, 2024 02:38
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Jun 14, 2024
@crazywoola crazywoola requested a review from laipz8200 June 14, 2024 07:11
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I noticed some translation issues. Could you fix them before we merge?

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some issues that need to be fixed.

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 15, 2024
@laipz8200 laipz8200 merged commit 795714b into langgenius:main Jun 15, 2024
7 checks passed
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
…ions (langgenius#5186)

Co-authored-by: teampen <136991215+teampen@users.noreply.github.com>
@takatost takatost mentioned this pull request Jun 28, 2024
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
…ions (langgenius#5186)

Co-authored-by: teampen <136991215+teampen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Custom Search JSON API Tool
4 participants