-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: exract Code Node provider for each supported scripting language #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
☕️ javascript
💪 enhancement
New feature or request
labels
May 7, 2024
bowenliang123
force-pushed
the
code-provider
branch
2 times, most recently
from
May 7, 2024 17:13
4e940aa
to
64d4843
Compare
Please wait for #4231 to be merged into main, thx! |
bowenliang123
force-pushed
the
code-provider
branch
from
May 13, 2024 08:35
bd57b8b
to
6aceb68
Compare
bowenliang123
force-pushed
the
code-provider
branch
from
May 14, 2024 10:25
55a880d
to
a4c865f
Compare
Hi @Yeuoly , I have fixed the JSON serialization problem as you reported offline and added proper tests for it. Please have a look. |
Yeuoly
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks~ |
TinsFox
pushed a commit
to TinsFox/dify
that referenced
this pull request
May 20, 2024
TinsFox
pushed a commit
to TinsFox/dify
that referenced
this pull request
May 28, 2024
dengpeng
pushed a commit
to dengpeng/dify
that referenced
this pull request
Jun 16, 2024
HuberyHuV1
pushed a commit
to HuberyHuV1/dify
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes