Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: exract Code Node provider for each supported scripting language #4164

Merged
merged 4 commits into from
May 17, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented May 7, 2024

Description

  • extract common CodeNodeProvider for Javascript and Python, to increase the cohesion for each supported programming language code node

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

  • no feature introduced, and all changes covered in exited intgration tests for CodeExecutor

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ☕️ javascript 💪 enhancement New feature or request labels May 7, 2024
@bowenliang123
Copy link
Contributor Author

cc @Yeuoly @takatost

@bowenliang123 bowenliang123 force-pushed the code-provider branch 2 times, most recently from 4e940aa to 64d4843 Compare May 7, 2024 17:13
@takatost takatost requested a review from Yeuoly May 8, 2024 00:55
@Yeuoly
Copy link
Collaborator

Yeuoly commented May 10, 2024

Please wait for #4231 to be merged into main, thx!

@bowenliang123
Copy link
Contributor Author

As #4231 was merged and this PR has been rebased, it is ready for review. Please have a check. @Yeuoly

@bowenliang123
Copy link
Contributor Author

bowenliang123 commented May 15, 2024

Hi @Yeuoly , I have fixed the JSON serialization problem as you reported offline and added proper tests for it. Please have a look.

Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 17, 2024
@Yeuoly Yeuoly merged commit 083ef2e into langgenius:main May 17, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the code-provider branch May 17, 2024 08:39
@bowenliang123
Copy link
Contributor Author

Thanks~

TinsFox pushed a commit to TinsFox/dify that referenced this pull request May 20, 2024
TinsFox pushed a commit to TinsFox/dify that referenced this pull request May 28, 2024
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants