test: migrate Explore controller sessions and ORM models to SQLite - #40537
Open
asukaminato0721 wants to merge 1 commit into
Open
test: migrate Explore controller sessions and ORM models to SQLite#40537asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
asukaminato0721
requested review from
QuantumGhost and
laipz8200
as code owners
August 11, 2026 22:16
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace mocked SQLAlchemy sessions in Explore audio, completion, message, parameter, saved-message, trial, and workflow controller tests with shared SQLite-backed sessions
replace App, InstalledApp, AppModelConfig, Workflow, Message, MessageFeedback, Account, Dataset, Tenant, and UploadFile stand-ins with real mapped instances
persist ownership/resource chains needed by secondary serializer queries while retaining mocks only for external services, DTO/Pydantic responses, pagination, Redis, crypto, and file-provider objects
Real persistence coverage
No production changes.
Size
725 additions + 439 deletions = 1,164 changed lines.
Validation
The full test suite was not run, per request.