Skip to content

test: migrate service boundary sessions and ORM models to SQLite - #40533

Open
asukaminato0721 wants to merge 1 commit into
langgenius:mainfrom
asukaminato0721:agent/sqlite-orm-service-repositories
Open

test: migrate service boundary sessions and ORM models to SQLite#40533
asukaminato0721 wants to merge 1 commit into
langgenius:mainfrom
asukaminato0721:agent/sqlite-orm-service-repositories

Conversation

@asukaminato0721

@asukaminato0721 asukaminato0721 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace remaining SQLAlchemy session doubles across eight scattered service-boundary test modules
  • execute external-knowledge filtering, ordering, pagination, and tenant isolation against real SQLite rows
  • execute metadata preflight validation and canonical-name writes with real datasets, documents, metadata, and bindings
  • seed provider summary state with real provider credentials, models, preferences, and cross-tenant decoys
  • use real unbound sessions for pass-through-only configuration and credit-pool paths
  • remove no-op Session/sessionmaker patches from workflow and RAG pipeline tests

Real persistence coverage

The tests now cover tenant-scoped external API pagination and search, the 100-row page cap, metadata validation before writes, canonical metadata binding persistence, document-owner scoping, lightweight provider-state SQL projections, extractor transaction ownership, and workflow/RAG session lifecycle using real SQLite sessions and engines.

Production changes

None.

Size

  • 307 additions, 336 deletions
  • 643 changed lines

This is intentionally below the preferred PR size because these are the remaining scattered service/session boundary cases; keeping them together avoids overlapping the larger dataset-service batches.

Validation

  • PASS: targeted tests for all eight affected modules (403 passed)
  • PASS: focused workflow, RAG pipeline, extractor, metadata, external knowledge, and provider-state cases
  • PASS: make lint
  • BLOCKED: make type-check — mypy 1.20.2 exits with an internal error in its bundled typeshed stdlib/zipimport.pyi:17; no project type diagnostic is emitted
  • PASS: structural audit found no mocked SQLAlchemy Session/sessionmaker/db.session result chains in the changed modules; remaining database wrappers contain real SQLite or deliberately unbound SQLAlchemy sessions

The full test suite was not run, per request.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-08-11 21:16:51.240142695 +0000
+++ /tmp/pyrefly_pr.txt	2026-08-11 21:16:41.303104327 +0000
@@ -7325,103 +7325,103 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:974:64
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1237:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1225:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1240:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1228:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1284:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1272:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1287:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1275:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1332:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1320:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1335:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1323:21
 ERROR Argument `() -> tuple[SimpleNamespace, Generator[NodeRunFailedEvent, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1380:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1368:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_first_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1398:64
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1386:64
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_second_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1426:70
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1414:70
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1527:63
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1515:63
 ERROR Argument `SimpleNamespace` is not assignable to parameter `current_user` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1527:96
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1515:96
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1564:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1552:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1567:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1555:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1617:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1605:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1620:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1608:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1672:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1660:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1675:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1663:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_first_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1690:69
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1678:69
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_second_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1721:70
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1709:70
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1731:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1719:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1731:32
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1719:32
 ERROR Argument `SimpleNamespace` is not assignable to parameter `user` with type `Account | EndUser` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1731:61
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1719:61
 ERROR Argument `() -> tuple[SimpleNamespace, Generator[object, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1762:20
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1750:20
 ERROR Argument `() -> tuple[SimpleNamespace, Iterator[Any]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1782:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1770:16
 ERROR Argument `() -> tuple[SimpleNamespace, Iterator[Any]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1802:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1790:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1841:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1829:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1844:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1832:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2029:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2017:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2032:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2020:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2077:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2065:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2080:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2068:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2126:18
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2114:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2129:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2117:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2211:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2199:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2211:32
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2199:32
 ERROR Argument `SimpleNamespace` is not assignable to parameter `user` with type `Account | EndUser` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2211:61
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2199:61
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2232:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2220:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2232:32
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2220:32
 ERROR Argument `SimpleNamespace` is not assignable to parameter `user` with type `Account | EndUser` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2232:61
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2220:61
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2268:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2256:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2271:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2259:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2286:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2274:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2289:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2277:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2333:18
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2321:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2336:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2324:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2374:18
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2362:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2377:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2365:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2391:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2379:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `current_user` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2393:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2381:13
 ERROR No matching overload found for function `typing.MutableMapping.update` called with arguments: (dict[str, object]) [no-matching-overload]
   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_transform_service.py:28:18
 ERROR No matching overload found for function `typing.MutableMapping.update` called with arguments: (dict[str, object]) [no-matching-overload]
@@ -7679,13 +7679,13 @@
 ERROR Argument `str` is not assignable to parameter `type` with type `Literal['api-key', 'no-auth']` in function `services.entities.external_knowledge_entities.external_knowledge_entities.Authorization.__init__` [bad-argument-type]
    --> tests/unit_tests/services/test_external_dataset_service.py:117:35
 ERROR Argument `None` is not assignable to parameter `api_settings` with type `dict[str, Any]` in function `services.external_knowledge_service.ExternalDatasetService.validate_api_list` [bad-argument-type]
-   --> tests/unit_tests/services/test_external_dataset_service.py:513:54
+   --> tests/unit_tests/services/test_external_dataset_service.py:398:54
 ERROR Argument `str | None` is not assignable to parameter `s` with type `bytearray | bytes | str` in function `json.loads` [bad-argument-type]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1077:31
+   --> tests/unit_tests/services/test_external_dataset_service.py:962:31
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1666:16
+    --> tests/unit_tests/services/test_external_dataset_service.py:1551:16
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/services/test_external_dataset_service.py:1667:16
+    --> tests/unit_tests/services/test_external_dataset_service.py:1552:16
 ERROR `in` is not supported between `None` and `str` [unsupported-operation]
    --> tests/unit_tests/services/test_feedback_service.py:134:16
 ERROR `not in` is not supported between `None` and `str` [unsupported-operation]
@@ -7704,6 +7704,10 @@
   --> tests/unit_tests/services/test_human_input_file_upload_service.py:55:20
 ERROR Argument `() -> Session` is not assignable to parameter `session_factory` with type `sessionmaker[@_]` in function `sqlalchemy.orm.scoping.scoped_session.__init__` [bad-argument-type]
    --> tests/unit_tests/services/test_message_service.py:181:31
+ERROR Object of class `NoneType` has no attribute `doc_metadata` [missing-attribute]
+   --> tests/unit_tests/services/test_metadata_service_session_boundary.py:157:12
+ERROR Object of class `NoneType` has no attribute `doc_metadata` [missing-attribute]
+   --> tests/unit_tests/services/test_metadata_service_session_boundary.py:196:12
 ERROR Argument `str | None` is not assignable to parameter `s` with type `bytearray | bytes | str` in function `json.loads` [bad-argument-type]
    --> tests/unit_tests/services/test_model_load_balancing_service.py:394:23
 ERROR `(tenant_id: str) -> service_with_fake_configurations._FakeProviderManager` is not assignable to attribute `_get_provider_manager` with type `(tenant_id: str) -> ProviderManager` [bad-assignment]
@@ -8131,11 +8135,11 @@
 ERROR `dict[str, str]` is not assignable to dict value type `list[Unknown] | str` [bad-assignment]
    --> tests/unit_tests/services/test_workflow_service.py:192:30
 ERROR `dict[@_, @_]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-assignment]
-    --> tests/unit_tests/services/test_workflow_service.py:3140:54
+    --> tests/unit_tests/services/test_workflow_service.py:3141:54
 ERROR Argument `Literal['invalid']` is not assignable to parameter `value` with type `AppMode | SQLCoreOperations[AppMode]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-    --> tests/unit_tests/services/test_workflow_service.py:3186:20
+    --> tests/unit_tests/services/test_workflow_service.py:3187:20
 ERROR Argument `dict[str, str | dict[str, str]]` is not assignable to parameter `node_config` with type `NodeConfigDict` in function `services.workflow_service.WorkflowService._build_human_input_node_for_debugging` [bad-argument-type]
-    --> tests/unit_tests/services/test_workflow_service.py:3217:65
+    --> tests/unit_tests/services/test_workflow_service.py:3218:65
 ERROR Object of class `MCPToolProvider` has no attribute `provider_icon` [missing-attribute]
   --> tests/unit_tests/services/tools/test_mcp_tools_transform.py:72:5
 ERROR Object of class `MCPToolProvider` has no attribute `masked_server_url` [missing-attribute]

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 58.89% 58.92% +0.03%
Strict coverage 58.47% 58.50% +0.03%
Typed symbols 38,906 38,922 +16
Untyped symbols 27,352 27,334 -18
Modules 3143 3143 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laipz8200 laipz8200 Awaiting requested review from laipz8200 laipz8200 is a code owner
@QuantumGhost QuantumGhost Awaiting requested review from QuantumGhost QuantumGhost is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asukaminato0721