refactor(apps): simplify query state and debounce URL writes#36043
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36043 +/- ##
==========================================
- Coverage 85.86% 85.86% -0.01%
==========================================
Files 4453 4454 +1
Lines 210742 210711 -31
Branches 39423 39410 -13
==========================================
- Hits 180956 180929 -27
+ Misses 26546 26542 -4
Partials 3240 3240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hyoban
previously approved these changes
May 11, 2026
faab187 to
603fe16
Compare
603fe16 to
9276b61
Compare
CodingOnStar
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAppsQueryStateinto a named, domain-specific hook API withquery,setKeywords,setTagIDs, andsetIsCreatedByMe.useDebouncefor TanStack Query input./appslist and kept the debounce constant in a local feature constant.Testing
pnpm --dir web test app/components/apps/__tests__/list.spec.tsx app/components/apps/hooks/__tests__/use-apps-query-state.spec.tsxweb/node_modules/.bin/tsgo --project web/tsconfig.json --pretty false