Skip to content

fix: use infotip for help glyphs#36008

Merged
lyzno1 merged 4 commits into
mainfrom
codex/fix-tooltip-infotip-semantics
May 11, 2026
Merged

fix: use infotip for help glyphs#36008
lyzno1 merged 4 commits into
mainfrom
codex/fix-tooltip-infotip-semantics

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 10, 2026

Summary

  • Replace question-mark help glyph Tooltip usages with Infotip across workflow, dataset, plugin, prompt, and model-provider UI surfaces.
  • Keep status/action Tooltip usages intact, including the invited-modal error/status case.
  • Update related tests for Infotip triggers and the added help button in subscription options.

Verification

  • web/node_modules/.bin/tsgo --project web/tsconfig.json
  • pnpm --dir web test app/components/workflow/nodes/_base/components/layout/tests/field-title.spec.tsx app/components/datasets/settings/index-method/tests/keyword-number.spec.tsx app/components/datasets/create/step-two/components/tests/general-chunking-options.spec.tsx app/components/plugins/plugin-detail-panel/multiple-tool-selector/tests/index.spec.tsx app/components/base/features/new-feature-panel/conversation-opener/tests/modal.spec.tsx app/components/base/features/new-feature-panel/tests/feature-card.spec.tsx app/components/workflow/nodes/trigger-schedule/components/tests/monthly-days-selector.spec.tsx app/components/workflow/nodes/trigger-schedule/components/tests/integration.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/tests/index.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/tests/list-view.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/tests/selector-view.spec.tsx app/components/header/account-setting/model-provider-page/provider-added-card/tests/model-load-balancing-configs.spec.tsx app/components/app/configuration/config-prompt/tests/simple-prompt-input.spec.tsx app/components/app/configuration/config-prompt/tests/advanced-prompt-input.spec.tsx
  • git diff --check

Notes

  • Targeted ESLint was run; the only remaining reported errors are existing no-explicit-any issues in the touched files, while the import ordering introduced by this change was fixed before commit.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 10, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.81%. Comparing base (9a2bea9) to head (ba0accb).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...gger-schedule/components/monthly-days-selector.tsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36008      +/-   ##
==========================================
+ Coverage   85.80%   85.81%   +0.01%     
==========================================
  Files        4453     4453              
  Lines      209844   209891      +47     
  Branches    39334    39348      +14     
==========================================
+ Hits       180054   180126      +72     
+ Misses      26576    26551      -25     
  Partials     3214     3214              
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.61% <94.73%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 requested a review from hyoban as a code owner May 11, 2026 04:07
@lyzno1 lyzno1 enabled auto-merge May 11, 2026 04:15
@lyzno1 lyzno1 added this pull request to the merge queue May 11, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 11, 2026
Merged via the queue into main with commit bd0d10a May 11, 2026
33 checks passed
@lyzno1 lyzno1 deleted the codex/fix-tooltip-infotip-semantics branch May 11, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants