Skip to content

fix(web): remove unsafe select value casts#36007

Merged
CodingOnStar merged 2 commits into
mainfrom
codex/typed-select-wrappers
May 11, 2026
Merged

fix(web): remove unsafe select value casts#36007
CodingOnStar merged 2 commits into
mainfrom
codex/typed-select-wrappers

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 10, 2026

Summary

  • bind dynamic select callbacks back to typed local option lists instead of casting callback strings in JSX
  • add a local Webhook method selector and tighten existing schedule/input/subscription/language/theme handlers
  • keep touched Select triggers accessible with labels or aria-labels, and convert markdown form enums to erasable const objects for lint

Verification

  • web/node_modules/.bin/tsgo --project web/tsconfig.json
  • pnpm --dir web exec eslint --cache --quiet app/components/workflow/nodes/trigger-schedule/components/frequency-selector.tsx app/components/workflow/nodes/trigger-webhook/panel.tsx app/signin/one-more-step.tsx app/signin/invite-settings/page.tsx app/components/base/form/components/field/input-type-select/index.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/index.tsx app/components/app/overview/settings/index.tsx app/components/base/theme-selector.tsx app/components/base/markdown-blocks/form.tsx
  • pnpm --dir web test app/components/workflow/nodes/trigger-schedule/components/tests/frequency-selector.spec.tsx app/components/workflow/nodes/trigger-webhook/tests/panel.spec.tsx app/components/base/form/components/field/input-type-select/tests/index.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/tests/index.spec.tsx app/components/app/overview/settings/tests/index.spec.tsx

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 10, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

❌ Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.80%. Comparing base (9a2bea9) to head (bd90410).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
web/app/components/app/overview/settings/index.tsx 50.00% 3 Missing ⚠️
...in-detail-panel/subscription-list/create/index.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36007      +/-   ##
==========================================
- Coverage   85.80%   85.80%   -0.01%     
==========================================
  Files        4453     4453              
  Lines      209844   209846       +2     
  Branches    39334    39333       -1     
==========================================
+ Hits       180054   180055       +1     
- Misses      26576    26577       +1     
  Partials     3214     3214              
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.58% <91.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 11, 2026
@CodingOnStar CodingOnStar added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit a643b05 May 11, 2026
33 checks passed
@CodingOnStar CodingOnStar deleted the codex/typed-select-wrappers branch May 11, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants