Skip to content

refactor(web): migrate drawer components to dify-ui and remove legacy drawer implementation#35982

Merged
lyzno1 merged 2 commits into
mainfrom
refactor/drawer-migration
May 9, 2026
Merged

refactor(web): migrate drawer components to dify-ui and remove legacy drawer implementation#35982
lyzno1 merged 2 commits into
mainfrom
refactor/drawer-migration

Conversation

@CodingOnStar
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Replaced instances of the legacy drawer component with the new dify-ui drawer primitives across various components.
  • Updated related tests to reflect changes in drawer implementation.
  • Removed the old drawer component and its associated tests to streamline the codebase.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

… drawer implementation

- Replaced instances of the legacy drawer component with the new dify-ui drawer primitives across various components.
- Updated related tests to reflect changes in drawer implementation.
- Removed the old drawer component and its associated tests to streamline the codebase.
@CodingOnStar CodingOnStar requested a review from lyzno1 May 9, 2026 14:59
@github-actions github-actions Bot added the web This relates to changes on the web. label May 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 79.56989% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.80%. Comparing base (24ea21d) to head (1c13026).

Files with missing lines Patch % Lines
...p/configuration/dataset-config/card-item/index.tsx 42.85% 4 Missing ⚠️
...config/agent/agent-tools/setting-built-in-tool.tsx 86.36% 3 Missing ⚠️
...omponents/app/configuration/configuration-view.tsx 25.00% 3 Missing ⚠️
web/app/components/app/log/list.tsx 50.00% 3 Missing ⚠️
web/app/components/datasets/hit-testing/index.tsx 62.50% 3 Missing ⚠️
...nts/plugins/plugin-detail-panel/endpoint-modal.tsx 62.50% 3 Missing ⚠️
...p/components/plugins/plugin-detail-panel/index.tsx 75.00% 3 Missing ⚠️
...ts/plugins/plugin-detail-panel/strategy-detail.tsx 82.35% 3 Missing ⚠️
...lugin-detail-panel/trigger/event-detail-drawer.tsx 75.00% 3 Missing ⚠️
...pp/components/tools/mcp/detail/provider-detail.tsx 40.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35982      +/-   ##
==========================================
- Coverage   85.82%   85.80%   -0.02%     
==========================================
  Files        4453     4452       -1     
  Lines      209795   209815      +20     
  Branches    39294    39298       +4     
==========================================
- Hits       180050   180033      -17     
- Misses      26530    26567      +37     
  Partials     3215     3215              
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.59% <79.56%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Enhanced the test for the overlay element to ensure it checks for the presence of the 'bg-background-overlay' class and excludes 'bg-transparent'.
- Improved readability and accuracy of the test assertions.
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 9, 2026
@CodingOnStar CodingOnStar marked this pull request as ready for review May 9, 2026 15:24
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 9, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit e48d7bb May 9, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the refactor/drawer-migration branch May 9, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants