Skip to content

refactor(web): migrate legacy tooltip callers#35961

Merged
lyzno1 merged 10 commits into
mainfrom
refactor/legacy-tooltip
May 9, 2026
Merged

refactor(web): migrate legacy tooltip callers#35961
lyzno1 merged 10 commits into
mainfrom
refactor/legacy-tooltip

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 9, 2026

Summary

  • migrate remaining legacy tooltip call sites to compound Tooltip, Infotip, or Popover based on content semantics
  • document Tooltip/Popover/Infotip usage boundaries and tighten the legacy tooltip import restriction
  • remove the legacy web base tooltip implementation directory

Verification

  • pnpm -C web type-check
  • pnpm -C web test --run

@github-actions github-actions Bot added the web This relates to changes on the web. label May 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 69.87952% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.79%. Comparing base (d5ad6ae) to head (70f9797).

Files with missing lines Patch % Lines
...w/nodes/_base/components/switch-plugin-version.tsx 0.00% 12 Missing ⚠️
...components/workflow/variable-inspect/listening.tsx 0.00% 7 Missing ⚠️
...es/trigger-plugin/components/trigger-form/item.tsx 0.00% 3 Missing ⚠️
...r-page/model-parameter-modal/status-indicators.tsx 83.33% 1 Missing ⚠️
...tail-panel/subscription-list/subscription-card.tsx 50.00% 1 Missing ⚠️
.../_base/components/mcp-tool-not-support-tooltip.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35961      +/-   ##
==========================================
- Coverage   85.80%   85.79%   -0.01%     
==========================================
  Files        4463     4460       -3     
  Lines      209623   209440     -183     
  Branches    39268    39211      -57     
==========================================
- Hits       179866   179696     -170     
+ Misses      26559    26552       -7     
+ Partials     3198     3192       -6     
Flag Coverage Δ
dify-ui 94.23% <ø> (ø)
web 86.74% <69.87%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 marked this pull request as ready for review May 9, 2026 04:54
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. refactor labels May 9, 2026
Copy link
Copy Markdown
Contributor

@CodingOnStar CodingOnStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 9, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 2bb1f09 May 9, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the refactor/legacy-tooltip branch May 9, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants