Skip to content

refactor(web): portal to follow elem migration#35892

Merged
lyzno1 merged 18 commits into
mainfrom
feat/portal-to-follow-elem-migaration
May 7, 2026
Merged

refactor(web): portal to follow elem migration#35892
lyzno1 merged 18 commits into
mainfrom
feat/portal-to-follow-elem-migaration

Conversation

@CodingOnStar
Copy link
Copy Markdown
Contributor

Summary

replace portal-to-follow-elem to dify-ui

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

CodingOnStar added 2 commits May 7, 2026 18:19
…mponents

- Removed legacy PortalToFollowElem references in various components.
- Introduced DropdownMenu and Popover components for improved UI interactions.
- Updated related tests to reflect the new component structure.
- Cleaned up unused imports and adjusted component props accordingly.
- Updated components to use the new Dialog component from @langgenius/dify-ui instead of the legacy Modal.
- Adjusted related test files to mock the Dialog component appropriately.
- Cleaned up imports and ensured consistent usage of the new Dialog structure across the application.
@CodingOnStar CodingOnStar requested a review from lyzno1 May 7, 2026 11:18
@github-actions github-actions Bot added the web This relates to changes on the web. label May 7, 2026
@CodingOnStar CodingOnStar changed the title feat/portal to follow elem migaration feat: portal to follow elem migaration May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 85.93750% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.81%. Comparing base (c6a5de3) to head (3840394).

Files with missing lines Patch % Lines
...ig-modal/visual-editor/edit-card/type-selector.tsx 0.00% 8 Missing ⚠️
...odes/_base/components/variable/var-type-picker.tsx 0.00% 4 Missing ⚠️
...app/components/base/chat/chat/answer/operation.tsx 90.32% 3 Missing ⚠️
web/app/components/base/tooltip/index.tsx 93.87% 3 Missing ⚠️
...panel/subscription-list/edit/apikey-edit-modal.tsx 89.28% 3 Missing ⚠️
...-panel/subscription-list/edit/oauth-edit-modal.tsx 57.14% 3 Missing ⚠️
...lugins/plugin-detail-panel/tool-selector/index.tsx 50.00% 3 Missing ⚠️
...in-detail-panel/subscription-list/create/index.tsx 71.42% 2 Missing ⚠️
...se/chat/chat-with-history/sidebar/rename-modal.tsx 66.66% 1 Missing ⚠️
...l-provider-page/model-auth/credential-selector.tsx 90.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35892      +/-   ##
==========================================
- Coverage   85.83%   85.81%   -0.02%     
==========================================
  Files        4462     4456       -6     
  Lines      209154   208973     -181     
  Branches    39116    39088      -28     
==========================================
- Hits       179519   179328     -191     
- Misses      26460    26470      +10     
  Partials     3175     3175              
Flag Coverage Δ
dify-ui 93.93% <ø> (ø)
web 86.73% <85.93%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 changed the title feat: portal to follow elem migaration feat: portal to follow elem migration May 7, 2026
@lyzno1 lyzno1 marked this pull request as ready for review May 7, 2026 12:50
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 7, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 7, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 9331024 May 7, 2026
33 checks passed
@lyzno1 lyzno1 deleted the feat/portal-to-follow-elem-migaration branch May 7, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants