Skip to content

test: migrate plugin permission tests to testcontainers#35884

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:issue/32454
May 7, 2026
Merged

test: migrate plugin permission tests to testcontainers#35884
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:issue/32454

Conversation

@escape0707
Copy link
Copy Markdown
Contributor

@escape0707 escape0707 commented May 7, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Part of #32454.
Migrate PluginPermissionService permission persistence coverage out of the mock-based unit test suite and into the Testcontainers integration suite. The new tests exercise get_permission and change_permission against real persisted TenantPluginPermission rows, including the update path preserving a single row per tenant.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@escape0707 escape0707 changed the title chore(test): Move plugin permission tests to testcontainers (#32454) chore(test): Move plugin permission tests to testcontainers May 7, 2026
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 7, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 7, 2026
@asukaminato0721 asukaminato0721 added this pull request to the merge queue May 7, 2026
@escape0707 escape0707 changed the title chore(test): Move plugin permission tests to testcontainers test: Migrate plugin permission tests to testcontainers May 7, 2026
@escape0707 escape0707 changed the title test: Migrate plugin permission tests to testcontainers test: migrate plugin permission tests to testcontainers May 7, 2026
Merged via the queue into langgenius:main with commit cd33270 May 7, 2026
28 checks passed
@escape0707 escape0707 deleted the issue/32454 branch May 7, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants