Skip to content

feat: add dify-ui autocomplete and combobox#35868

Merged
lyzno1 merged 6 commits into
mainfrom
feat/combobox-autocomplete
May 7, 2026
Merged

feat: add dify-ui autocomplete and combobox#35868
lyzno1 merged 6 commits into
mainfrom
feat/combobox-autocomplete

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 7, 2026

Summary

  • add composable Dify UI Autocomplete and Combobox primitives built on Base UI
  • document primitive selection and overlay z-index guidance
  • include Storybook examples and tests

Starts #35867

Testing

  • component tests added and passing
  • stories added for visual coverage

@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. javascript Pull requests that update javascript code labels May 7, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 7, 2026
@lyzno1 lyzno1 enabled auto-merge May 7, 2026 04:07
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.82%. Comparing base (8fd616d) to head (c4b0390).

Files with missing lines Patch % Lines
packages/dify-ui/src/autocomplete/index.tsx 95.00% 3 Missing ⚠️
packages/dify-ui/src/combobox/index.tsx 96.15% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #35868    +/-   ##
========================================
  Coverage   85.82%   85.82%            
========================================
  Files        4458     4460     +2     
  Lines      208954   209092   +138     
  Branches    39071    39112    +41     
========================================
+ Hits       179328   179460   +132     
- Misses      26451    26457     +6     
  Partials     3175     3175            
Flag Coverage Δ
dify-ui 93.93% <95.65%> (+0.66%) ⬆️
web 86.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@CodingOnStar CodingOnStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 7, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 7, 2026
@lyzno1 lyzno1 removed this pull request from the merge queue due to a manual request May 7, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 7, 2026
@lyzno1 lyzno1 removed this pull request from the merge queue due to a manual request May 7, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit a24ec60 May 7, 2026
36 checks passed
@lyzno1 lyzno1 deleted the feat/combobox-autocomplete branch May 7, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants