Skip to content

refactor(web): migrate workflow panel context menu primitive#35787

Merged
lyzno1 merged 3 commits into
mainfrom
codex/workflow-panel-contextmenu-primitive
May 4, 2026
Merged

refactor(web): migrate workflow panel context menu primitive#35787
lyzno1 merged 3 commits into
mainfrom
codex/workflow-panel-contextmenu-primitive

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 4, 2026

Summary

  • Migrate workflow panel context menu to @langgenius/dify-ui/context-menu primitives
  • Store pane menu viewport coordinates directly for virtual anchor positioning
  • Update workflow menu tests to render real primitives and AddBlock

Tests

  • pnpm -C web test app/components/workflow/__tests__/panel-contextmenu.spec.tsx app/components/workflow/hooks/__tests__/use-panel-interactions.spec.ts app/components/workflow/store/workflow/__tests__/panel-slice.spec.ts app/components/workflow/store/__tests__/workflow-store.spec.ts app/components/workflow/hooks/__tests__/use-selection-interactions.spec.ts
  • pnpm -C web exec eslint app/components/workflow/panel-contextmenu.tsx app/components/workflow/hooks/use-panel-interactions.ts app/components/workflow/store/workflow/panel-slice.ts app/components/workflow/__tests__/panel-contextmenu.spec.tsx app/components/workflow/hooks/__tests__/use-panel-interactions.spec.ts app/components/workflow/hooks/__tests__/use-selection-interactions.spec.ts app/components/workflow/store/workflow/__tests__/panel-slice.spec.ts app/components/workflow/store/__tests__/workflow-store.spec.ts
  • pnpm -C web type-check

@lyzno1 lyzno1 requested review from iamjoel and zxhlyh as code owners May 4, 2026 13:58
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 4, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 4, 2026
@lyzno1 lyzno1 force-pushed the codex/workflow-panel-contextmenu-primitive branch from aa107eb to 6f248c8 Compare May 4, 2026 14:04
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 79.06977% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.66%. Comparing base (8f3e42e) to head (9d3b921).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
web/app/components/workflow/panel-contextmenu.tsx 75.67% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #35787   +/-   ##
=======================================
  Coverage   85.66%   85.66%           
=======================================
  Files        4461     4461           
  Lines      209051   209059    +8     
  Branches    39074    39080    +6     
=======================================
+ Hits       179084   179092    +8     
  Misses      26803    26803           
  Partials     3164     3164           
Flag Coverage Δ
dify-ui 93.01% <ø> (ø)
web 86.43% <79.06%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 enabled auto-merge May 4, 2026 14:22
@lyzno1 lyzno1 added this pull request to the merge queue May 4, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 4, 2026
Merged via the queue into main with commit 90fe54c May 4, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the codex/workflow-panel-contextmenu-primitive branch May 4, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants