Skip to content

refactor(web): migrate subscription create modal to dialog#35721

Merged
lyzno1 merged 2 commits into
mainfrom
codex/subscription-dialog-modal
Apr 30, 2026
Merged

refactor(web): migrate subscription create modal to dialog#35721
lyzno1 merged 2 commits into
mainfrom
codex/subscription-dialog-modal

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented Apr 30, 2026

Summary

  • migrate the trigger subscription create modal from the legacy base Modal to @langgenius/dify-ui/dialog
  • preserve the existing modal layout, sizing, disabled state, footer actions, and encrypted bottom slot behavior
  • remove the unit test mock for the legacy base modal

Tests

  • pnpm eslint app/components/plugins/plugin-detail-panel/subscription-list/create/common-modal.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/tests/common-modal.spec.tsx --fix --quiet
  • pnpm test app/components/plugins/plugin-detail-panel/subscription-list/create/tests/common-modal.spec.tsx

@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. refactor labels Apr 30, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (fe2f7a8) to head (8766b36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #35721   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files        4459     4459           
  Lines      209085   209088    +3     
  Branches    39107    39110    +3     
=======================================
+ Hits       179149   179155    +6     
+ Misses      26769    26766    -3     
  Partials     3167     3167           
Flag Coverage Δ
dify-ui 93.01% <ø> (ø)
web 86.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 force-pushed the codex/subscription-dialog-modal branch from 2d25a24 to ea1f8aa Compare April 30, 2026 04:32
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Apr 30, 2026
@lyzno1 lyzno1 enabled auto-merge April 30, 2026 04:39
@lyzno1 lyzno1 added this pull request to the merge queue Apr 30, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 30, 2026
Merged via the queue into main with commit 195ff47 Apr 30, 2026
33 checks passed
@lyzno1 lyzno1 deleted the codex/subscription-dialog-modal branch April 30, 2026 05:40
lyzno1 added a commit that referenced this pull request Apr 30, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants