fix: preserve single-run input variable types#35710
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35710 +/- ##
==========================================
+ Coverage 85.68% 85.73% +0.04%
==========================================
Files 4460 4458 -2
Lines 209183 208973 -210
Branches 39040 39040
==========================================
- Hits 179241 179163 -78
+ Misses 26779 26645 -134
- Partials 3163 3165 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6be3e9c to
11f3673
Compare
lyzno1
approved these changes
May 4, 2026
Member
lyzno1
left a comment
There was a problem hiding this comment.
No blocking issues found.
Verified locally:
pnpm test app/components/workflow/nodes/_base/hooks/__tests__/use-one-step-run.spec.tspnpm type-checkpnpm exec eslint app/components/workflow/nodes/_base/hooks/__tests__/use-one-step-run.spec.ts
Small non-blocking suggestion: consider adding one more fallback test for an unresolved variable with options, asserting it becomes InputVarType.select and preserves options. The implementation already handles this path, but the current spec only covers the number fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes single-step run inputs so referenced variables keep their expected input types instead of falling back to text inputs.
Change List
value_typeas a fallback when a single-run variable cannot be resolved from workflow output metadata.sys.*variables by their full variable name across available workflow variable groups.sys.timestampandsys.dialogue_count.Testing
web/app/components/workflow/nodes/_base/hooks/use-one-step-run.ts.Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods