Skip to content

refactor(web): migrate rich tooltip overlays#35675

Merged
lyzno1 merged 5 commits into
mainfrom
codex/migrate-overlay-popovers
Apr 29, 2026
Merged

refactor(web): migrate rich tooltip overlays#35675
lyzno1 merged 5 commits into
mainfrom
codex/migrate-overlay-popovers

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented Apr 29, 2026

Summary

  • migrate rich legacy tooltip overlays to semantic Popover/Dialog primitives
  • keep short icon labels on the new dify-ui Tooltip primitive
  • split the Jinja infotip trigger from its switch so toggling does not open the popup

Testing

  • pnpm -C web type-check
  • pnpm -C web test app/components/datasets/external-api/external-api-modal/tests/index.spec.tsx
  • git diff --check

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update javascript code labels Apr 29, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 69.09091% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.68%. Comparing base (6fafeec) to head (1a14f1d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../workflow/nodes/_base/components/prompt/editor.tsx 0.00% 7 Missing ⚠️
...p/configuration/config/agent/agent-tools/index.tsx 50.00% 3 Missing ⚠️
web/app/components/app/overview/app-card.tsx 80.00% 3 Missing ⚠️
...datasets/external-api/external-api-modal/index.tsx 83.33% 3 Missing ⚠️
web/app/components/tools/mcp/mcp-service-card.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35675      +/-   ##
==========================================
- Coverage   85.68%   85.68%   -0.01%     
==========================================
  Files        4459     4459              
  Lines      209019   209034      +15     
  Branches    39079    39093      +14     
==========================================
+ Hits       179102   179112      +10     
- Misses      26751    26756       +5     
  Partials     3166     3166              
Flag Coverage Δ
dify-ui 93.01% <ø> (ø)
web 86.48% <69.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2026
@lyzno1 lyzno1 enabled auto-merge April 29, 2026 06:43
@lyzno1 lyzno1 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit 0e55dcb Apr 29, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the codex/migrate-overlay-popovers branch April 29, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants