fix(workflow): handle file-preview URLs in node output display#34150
Merged
Blackoutta merged 1 commit intoMay 8, 2026
Conversation
Enable showFileList on CodeEditor components for process_data and outputs in both the node panel and result panel views. The CodeEditor already extracts file objects via getFilesInLogs but the file list was never rendered because showFileList was not set. This matches the existing behavior in output-panel.tsx which already had showFileList enabled.
dosubot
Bot
added
the
size:XS
crazywoola
approved these changes
Mar 31, 2026
|
Hi @crazywoola @iamjoel @zxhlyh can anyone merge this request to fix the file-preview? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #34006.
The
CodeEditorcomponent already extracts file objects from JSON data viagetFilesInLogsand builds a file list, but theshowFileListprop was not enabled on the process data and output editors innode.tsxandresult-panel.tsx. This meant file-preview URLs were only visible as raw text in the JSON viewer and could not be clicked or downloaded.This adds
showFileListto the CodeEditor instances for process data and outputs in both the node panel (used in workflow run logs) and the result panel (used in the side panel detail view), matching the existing behavior inoutput-panel.tsxwhich already had this prop set.Screenshots
N/A
Checklist
cd web && npx lint-stagedto appease the lint gods