Skip to content

chore(dep): move hono and @hono/node-server to devDependencies#33742

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
bowenliang123:hono-dev
Mar 23, 2026
Merged

chore(dep): move hono and @hono/node-server to devDependencies#33742
crazywoola merged 1 commit intolanggenius:mainfrom
bowenliang123:hono-dev

Conversation

@bowenliang123
Copy link
Copy Markdown
Contributor

@bowenliang123 bowenliang123 commented Mar 19, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@bowenliang123 bowenliang123 requested a review from iamjoel as a code owner March 19, 2026 07:45
Copilot AI review requested due to automatic review settings March 19, 2026 07:45
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Mar 19, 2026
@github-actions github-actions bot added web This relates to changes on the web. and removed dependencies Pull requests that update a dependency file labels Mar 19, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project's dependency management by reclassifying several packages. The hono, @hono/node-server, and sharp libraries, which are primarily used during development, have been correctly moved from production dependencies to devDependencies. This change improves the accuracy of the dependency graph and can lead to smaller production builds by excluding unnecessary packages.

Highlights

  • Dependency Management: Moved hono, @hono/node-server, and sharp packages from dependencies to devDependencies in web/package.json.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly moves hono and @hono/node-server to devDependencies as they are only used for development purposes. However, it also moves the sharp package, which is an undocumented change in the PR description. The sharp package is used by Next.js for production image optimization. Moving it to devDependencies will exclude it from the production build, likely causing a performance degradation. I have added a comment to revert this change.

I am having trouble creating individual review comments. Click here to see my feedback.

web/package.json (154)

high

Moving sharp to devDependencies is likely a mistake. Next.js uses sharp for production image optimization if it's installed. Since this project uses output: 'standalone' for its production build (as configured in next.config.ts), dependencies from devDependencies are not included in the final build artifact. This will result in Next.js falling back to a less performant image optimization library, causing a performance regression in production.

Please move sharp back to dependencies.

Also, please note that this change was not mentioned in the pull request title or description, which can be misleading for reviewers.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the web workspace dependency classification by moving development-only packages out of dependencies and into devDependencies, reducing the production install surface for the web app.

Changes:

  • Moved hono and @hono/node-server from dependencies to devDependencies.
  • Updated pnpm-lock.yaml to reflect the dependency section changes.
  • (Also moved sharp to devDependencies as part of the same dependency re-bucketing.)

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
web/package.json Reclassifies hono, @hono/node-server (and sharp) as devDependencies.
web/pnpm-lock.yaml Lockfile update reflecting the dependency section moves.
Files not reviewed (1)
  • web/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

web/package.json:235

  • sharp was moved from dependencies to devDependencies as part of this change, but the PR title/summary only mention hono and @hono/node-server. If the sharp move is intentional, please update the PR title/description to reflect it (and double-check it isn’t required in production installs that omit devDependencies); otherwise, revert the sharp dependency move so the PR stays scoped.
    "nock": "14.0.11",
    "postcss": "8.5.8",
    "postcss-js": "5.1.0",
    "react-server-dom-webpack": "19.2.4",
    "sass": "1.98.0",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves hono and @hono/node-server from runtime dependencies to dev-only dependencies in the web package, aligning with their actual usage (dev proxy server tooling).

Changes:

  • Moved hono from dependencies to devDependencies in web/package.json
  • Moved @hono/node-server from dependencies to devDependencies in web/package.json
  • Updated web/pnpm-lock.yaml importers sections accordingly

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
web/package.json Reclassifies Hono-related packages as devDependencies.
web/pnpm-lock.yaml Lockfile updates reflecting dependency-to-devDependency move.
Files not reviewed (1)
  • web/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 23, 2026
@crazywoola crazywoola merged commit d7cafc6 into langgenius:main Mar 23, 2026
19 checks passed
@bowenliang123 bowenliang123 deleted the hono-dev branch March 23, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants