chore(dep): move hono and @hono/node-server to devDependencies#33742
chore(dep): move hono and @hono/node-server to devDependencies#33742crazywoola merged 1 commit intolanggenius:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project's dependency management by reclassifying several packages. The Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly moves hono and @hono/node-server to devDependencies as they are only used for development purposes. However, it also moves the sharp package, which is an undocumented change in the PR description. The sharp package is used by Next.js for production image optimization. Moving it to devDependencies will exclude it from the production build, likely causing a performance degradation. I have added a comment to revert this change.
I am having trouble creating individual review comments. Click here to see my feedback.
web/package.json (154)
Moving sharp to devDependencies is likely a mistake. Next.js uses sharp for production image optimization if it's installed. Since this project uses output: 'standalone' for its production build (as configured in next.config.ts), dependencies from devDependencies are not included in the final build artifact. This will result in Next.js falling back to a less performant image optimization library, causing a performance regression in production.
Please move sharp back to dependencies.
Also, please note that this change was not mentioned in the pull request title or description, which can be misleading for reviewers.
There was a problem hiding this comment.
Pull request overview
This PR updates the web workspace dependency classification by moving development-only packages out of dependencies and into devDependencies, reducing the production install surface for the web app.
Changes:
- Moved
honoand@hono/node-serverfromdependenciestodevDependencies. - Updated
pnpm-lock.yamlto reflect the dependency section changes. - (Also moved
sharptodevDependenciesas part of the same dependency re-bucketing.)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/package.json | Reclassifies hono, @hono/node-server (and sharp) as devDependencies. |
| web/pnpm-lock.yaml | Lockfile update reflecting the dependency section moves. |
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
web/package.json:235
sharpwas moved fromdependenciestodevDependenciesas part of this change, but the PR title/summary only mentionhonoand@hono/node-server. If thesharpmove is intentional, please update the PR title/description to reflect it (and double-check it isn’t required in production installs that omit devDependencies); otherwise, revert thesharpdependency move so the PR stays scoped.
"nock": "14.0.11",
"postcss": "8.5.8",
"postcss-js": "5.1.0",
"react-server-dom-webpack": "19.2.4",
"sass": "1.98.0",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Moves hono and @hono/node-server from runtime dependencies to dev-only dependencies in the web package, aligning with their actual usage (dev proxy server tooling).
Changes:
- Moved
honofromdependenciestodevDependenciesinweb/package.json - Moved
@hono/node-serverfromdependenciestodevDependenciesinweb/package.json - Updated
web/pnpm-lock.yamlimporters sections accordingly
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/package.json | Reclassifies Hono-related packages as devDependencies. |
| web/pnpm-lock.yaml | Lockfile updates reflecting dependency-to-devDependency move. |
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods