refactor: port some if else to match

[asukaminato0721]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #30001

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @asukaminato0721, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant code refactoring effort across several Python files. The primary goal is to modernize the codebase by replacing various if/elif/else conditional statements with Python's match/case construct. This change enhances the readability, maintainability, and potentially the extensibility of the code, particularly in areas dealing with multiple distinct conditions such as data source types, file extensions, and workflow node types.

Highlights

• Code Refactoring to Match/Case Statements: Conditional logic across multiple Python files has been refactored from traditional if/elif/else blocks to the more modern and readable match/case statements. This improves code clarity and maintainability.
• Enhanced Data Source Handling: The api/controllers/console/datasets/datasets.py file now uses match/case for handling different data source types (upload_file, notion_import, website_crawl), streamlining the logic for creating ExtractSetting objects.
• Improved Workflow Tracing Logic: In api/core/ops/arize_phoenix_trace/arize_phoenix_trace.py, the determination of OpenInference span kinds based on workflow node types has been updated to use match/case with the NodeType enum, making the code more explicit and robust.
• Streamlined Data Extraction Logic: The api/core/rag/extractor/extract_processor.py file has undergone significant refactoring, converting complex nested if/elif/else structures for datasource_type and file_extension into match/case statements, which simplifies the file extraction process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This PR refactors multiple Python files to replace if/elif/else chains with Python 3.10+ match/case statements for improved readability and maintainability.

Changes:

• Converted conditional chains to match/case statements across 7 files
• Added NodeType enum import in arize_phoenix_trace.py to support enum-based matching
• Nested match statements appropriately for complex conditional logic

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
api/core/rag/extractor/extract_processor.py	Refactored datasource type and file extension conditionals to nested match statements
api/core/rag/datasource/vdb/opensearch/opensearch_vector.py	Converted authentication method selection to match statement
api/core/prompt/simple_prompt_transform.py	Refactored special variable key handling to match statement
api/core/ops/weave_trace/entities/weave_trace_entity.py	Converted field name conditionals to match statement in validator
api/core/ops/langsmith_trace/entities/langsmith_trace_entity.py	Converted field name conditionals to match statement in validator
api/core/ops/arize_phoenix_trace/arize_phoenix_trace.py	Refactored node type conditionals to match statement with NodeType enum import
api/controllers/console/datasets/datasets.py	Converted data source type conditionals to match statement

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request refactors several files to use Python's match/case statement instead of if/elif/else chains. The changes improve code readability and are well-implemented. I've found one minor point of improvement for code clarity. Overall, this is a good refactoring effort.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[github-actions]

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	0.00%	43.74%	+43.74%
Strict coverage	0.00%	43.26%	+43.26%
Typed symbols	0	21,996	+21,996
Untyped symbols	0	28,603	+28,603
Modules	0	2548	+2,548