feat: support SQLALCHEMY_POOL_RESET_ON_RETURN config

[fatelei]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #31155

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances database connection management by adding support for the SQLALCHEMY_POOL_RESET_ON_RETURN configuration. This feature provides finer control over the state of database connections upon their return to the connection pool, helping to prevent issues related to stale or inconsistent transaction states and improving overall application stability and reliability when interacting with the database.

Highlights

• New Configuration Option: Introduced SQLALCHEMY_POOL_RESET_ON_RETURN to control the behavior of database connections when they are returned to the connection pool. This allows specifying whether connections should be committed, rolled back, or left as is.
• Default Behavior: The default setting for SQLALCHEMY_POOL_RESET_ON_RETURN is rollback, ensuring that any uncommitted transactions are rolled back when a connection is returned to the pool.
• Configuration Integration: The new configuration is integrated into the application's settings, allowing it to be defined via environment variables and dynamically applied to SQLAlchemy engine options.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for the SQLALCHEMY_POOL_RESET_ON_RETURN configuration, setting a default of 'rollback' to improve database connection handling. The implementation is sound, adding the new configuration to the pydantic settings and applying it to the SQLAlchemy engine options. However, this change breaks an existing unit test which was not updated as part of this PR. Please address the failing test to ensure the integrity of the codebase.

[github-actions]

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	0.00%	41.39%	+41.39%
Strict coverage	0.00%	40.91%	+40.91%
Typed symbols	0	20,735	+20,735
Untyped symbols	0	29,708	+29,708
Modules	0	2538	+2,538