Skip to content

Conversation

@laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Jan 6, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Follow-up #30531 (comment)

  • Inject sessionmaker into ConversationVariableUpdater and remove the factory indirection.
  • Update callers to build the updater with the shared session factory instead of accessing db.engine.
  • Motivation: avoid per-update engine access and improve dependency injection consistency.
  • Dependencies: none.

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

…le updater and update call sites

Tests not run (not requested).
…variable_updater.py)

chore: run make type-check (no errors)
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the ConversationVariableUpdater class to enhance its modularity and testability. The updater now receives a SQLAlchemy sessionmaker via its constructor, eliminating its direct dependency on a global database engine. This change promotes better dependency injection practices across the application where the updater is used.

Highlights

  • Dependency Injection: The ConversationVariableUpdater now accepts a sessionmaker during initialization, moving away from direct global db.engine usage.
  • Improved Testability: By injecting the sessionmaker, the ConversationVariableUpdater becomes easier to test in isolation.
  • Code Cleanup: The conversation_variable_updater_factory function has been removed, simplifying the instantiation process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@laipz8200 laipz8200 changed the title Give ConversationVariableUpdaterImpl a db sessionmaker (vibe-kanban) refactor(api): inject sessionmaker into conversation variable updater Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the ConversationVariableUpdater by renaming ConversationVariableUpdaterImpl to ConversationVariableUpdater and modifying its constructor to accept a sessionmaker for database session management, thereby decoupling it from a global db.engine instance. The conversation_variable_updater_factory function has been removed, and ConversationVariableUpdater is now instantiated directly with session_factory.get_session_maker() in app_runner.py and conversation_service.py. Corresponding import statements were updated across the affected files.

@laipz8200 laipz8200 marked this pull request as ready for review January 6, 2026 06:51
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 6, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2026
@QuantumGhost QuantumGhost merged commit d12b91a into main Jan 6, 2026
16 of 17 checks passed
@QuantumGhost QuantumGhost deleted the 817a-give-conversatio branch January 6, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants