fix: remove hardcoded 48-character limit from text inputs #30156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the DEFAULT_VALUE_MAX_LEN (48) fallback from text input components. When max_length is not configured, inputs should have no character limit. This fixes an issue where text inputs in workflow and chatflow were always limited to 48 characters even when the max_length setting was removed. The fix: - Removes DEFAULT_VALUE_MAX_LEN fallback from Input maxLength prop - Only applies maxLength when max_length is explicitly configured - Adds tests to verify maxLength behavior fixes langgenius#26940 Signed-off-by: majiayu000 <1835304752@qq.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
dosubot
bot
added
the
size:M
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the hardcoded 48-character fallback limit from text input components, allowing inputs to have no character limit when max_length is not explicitly configured. Previously, all text inputs without a configured max_length would default to a 48-character limit via DEFAULT_VALUE_MAX_LEN.
Key Changes:
- Removed
DEFAULT_VALUE_MAX_LENfallback from text input components across the application - Updated validation logic to only enforce length limits when explicitly configured
- Added tests to verify maxLength attribute behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/app/components/share/text-generation/run-once/index.tsx | Removed DEFAULT_VALUE_MAX_LEN import and fallback from text input maxLength prop |
| web/app/components/share/text-generation/run-once/index.spec.tsx | Added tests verifying maxLength attribute is only present when max_length is configured |
| web/app/components/share/text-generation/index.tsx | Removed DEFAULT_VALUE_MAX_LEN import and updated batch input validation to only check length when max_length is set |
| web/app/components/app/configuration/prompt-value-panel/index.tsx | Removed DEFAULT_VALUE_MAX_LEN import and fallback from both string and number input maxLength props |
| web/app/components/app/configuration/debug/chat-user-input.tsx | Removed DEFAULT_VALUE_MAX_LEN import and fallback from both string and number input maxLength props |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crazywoola
previously approved these changes
Jan 14, 2026
dosubot
bot
added
size:L
dosubot
bot
added
size:M
crazywoola
approved these changes
Jan 15, 2026
This was referenced Jan 20, 2026
This was referenced Jan 21, 2026
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_VALUE_MAX_LEN(48 characters) fallback from text input componentsmax_lengthis not configured, inputs now have no character limit as expectedmaxLengthwhen explicitly configured by the userTest plan
fixes #26940