Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose files version #2920

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

Kennytian
Copy link
Contributor

@Kennytian Kennytian commented Mar 20, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

WARN[0000] /root/dify/docker/docker-compose.yaml: `version` is obsolete

This update resolved a WARN, please accept it.

Type of Change

  • Improvement,including but not limited to code refactoring, performance optimization, and UI/UX improvement

How Has This Been Tested?

  • Manual Test

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 20, 2024
@Kennytian Kennytian changed the title Update docker-compose.middleware.yaml Update docker-compose files version.yaml Mar 20, 2024
@Kennytian
Copy link
Contributor Author

Here is my Docker and Docker Compose version:

Docker version 25.0.5, build 5dc9bcc
Docker Compose version v2.25.0

@bowenliang123
Copy link
Contributor

When did you have this warning? It never comes into my daily builds and usages.
List the command you've run.

@bowenliang123
Copy link
Contributor

Furthermore, why 3 is better than 3.1 while the latter one is warned as obsolete one. Any Docker's official docs for supported value for the version field?

@takatost
Copy link
Collaborator

My understanding of this warn is that the version has already been deprecated, docker compose is backward compatible. I think we can delete this version, right?

@bowenliang123
Copy link
Contributor

OK, I found the compatibility matrix docs here: https://docs.docker.com/compose/compose-file/compose-versioning/#compatibility-matrix

@bowenliang123
Copy link
Contributor

According to Versioning, it's alright to use '3' here, better than '3.x' which could be deprecated on certain docker engine versions.

@Kennytian Kennytian changed the title Update docker-compose files version.yaml Update docker-compose files version Mar 20, 2024
@Kennytian
Copy link
Contributor Author

If only the major version is given (version: '3'), the latest minor version is used by default.

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dosubot dosubot bot added the lgtm label Mar 21, 2024
@crazywoola crazywoola requested a review from takatost March 21, 2024 01:11
@Kennytian
Copy link
Contributor Author

@takatost Please review my commit code.

@takatost takatost merged commit 16af509 into langgenius:main Mar 21, 2024
7 checks passed
@Kennytian Kennytian deleted the patch-1 branch March 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants