-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-compose files version #2920
Conversation
Update docker-compose.yaml
Here is my Docker and Docker Compose version:
|
When did you have this warning? It never comes into my daily builds and usages. |
Furthermore, why |
My understanding of this warn is that the version has already been deprecated, docker compose is backward compatible. I think we can delete this version, right? |
OK, I found the compatibility matrix docs here: https://docs.docker.com/compose/compose-file/compose-versioning/#compatibility-matrix |
According to Versioning, it's alright to use '3' here, better than '3.x' which could be deprecated on certain docker engine versions. |
If only the major version is given (version: '3'), the latest minor version is used by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@takatost Please review my commit code. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This update resolved a WARN, please accept it.
Type of Change
How Has This Been Tested?
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes