Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 3, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

resolve #29052, start node support json

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@fatelei fatelei requested a review from QuantumGhost as a code owner December 3, 2025 03:32
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 3, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flexibility and robustness of workflow inputs by enabling the 'start node' to accept and validate JSON objects. This feature allows users to define structured data inputs for their workflows, which are then automatically validated against a specified JSON Schema, improving data quality and reducing potential errors at the workflow's entry point.

Highlights

  • JSON Object Input Support: The 'start node' in the workflow system now supports a new input type, JSON_OBJECT, allowing structured JSON data to be passed as user input.
  • JSON Schema Validation: Inputs of type JSON_OBJECT can now be validated against an optional JSON Schema, ensuring data integrity and adherence to predefined structures. This includes checks for required fields, proper JSON formatting, and schema compliance.
  • Dependency Addition: The jsonschema library has been added as a new dependency to enable the JSON Schema validation functionality.
  • New Test Coverage: A new unit test file has been introduced to specifically verify the correct behavior of JSON object input validation with schemas in the start node.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for JSON object variables in the start node, including validation against a JSON schema. The changes in the backend are well-structured, introducing a new JSON_OBJECT variable type and implementing the validation logic in the StartNode. The addition of a new dependency jsonschema is appropriate.

My review focuses on improving the code clarity and test coverage. I've suggested refactoring a small part of the validation logic to remove unreachable code and translating Chinese comments to English for consistency. Most importantly, I've recommended adding more comprehensive test cases to cover various edge cases and error scenarios, which will make the new feature more robust.

Overall, this is a good feature addition. Addressing the feedback will improve the quality and maintainability of the code.

@fatelei fatelei force-pushed the start_node_json branch 4 times, most recently from 83e7681 to d048698 Compare December 3, 2025 05:39
@fatelei fatelei requested a review from laipz8200 as a code owner December 3, 2025 05:39
QuantumGhost
QuantumGhost previously approved these changes Dec 3, 2025
Copy link
Collaborator

@QuantumGhost QuantumGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also requires updating to documentation.

Other changes LGTM.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start node support json schema

3 participants