-
Notifications
You must be signed in to change notification settings - Fork 19.2k
feat: Workflow-Level Credential Override for Model Providers #28850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
40078b0 to
c00acf5
Compare
|
Thanks for working on this feature! I opened the original issue #28815 and have been exploring implementations as well. Feedback on the ImplementationWhat I Like
UI Improvement SuggestionThe current text input approach requires users to manually type or paste credential IDs: <input
type='text'
placeholder={t(`${i18nPrefix}.credentialIdPlaceholder`)}
value={inputs.model?.credential_override?.credential_id || ''}
...
/>This has some UX challenges:
Suggested improvement: A dropdown selector that fetches available credentials from the provider: // Fetch available credentials from the model provider
const { data: modelProviders } = useModelProviders()
const availableCredentials = modelProviders
?.find(p => p.provider === model?.provider)
?.custom_configuration?.available_credentials || []
// Render as dropdown
<select value={credentialId} onChange={handleChange}>
<option value="">Default (workspace credential)</option>
{availableCredentials.map(cred => (
<option key={cred.credential_id} value={cred.credential_id}>
{cred.credential_name}
</option>
))}
</select>This approach:
Minor Suggestions
Overall, great work on the backend logic and tests! The dropdown UI would make this feature much more user-friendly. |
8d4367e to
22c1307
Compare
done, change to select option |
22c1307 to
f37c6dd
Compare
QuantumGhost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also affects credential management in EE version. cc @GarfieldDai What's your idea about this feature?
529a4f4 to
caa905e
Compare
caa905e to
c526aa9
Compare
|
Can you add an option to either select a pre-configured key or use a text box to enter a custom key? This key could be passed as a parameter, so that the new WebHook trigger can also accept a key, making it easier for callers to use their own models. |
Important
Fixes #<issue number>.Summary
fix issue #28815 enable llm node can have a api key config instead of using global api key config
Screenshots
before
after
test result
using default api key
using select api key
knowledge node
parameter extractor node
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods