Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for smtp when send email #2409

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

jonahcui
Copy link
Contributor

@jonahcui jonahcui commented Feb 6, 2024

虽然 resend 很好用,但是 smtp 还是要支持一下的,支持使用 smtp 发送邀请邮件

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 6, 2024
@zxhlyh zxhlyh requested a review from takatost February 6, 2024 09:19
@crazywoola
Copy link
Member

Please add my wechat: crazyphage, I will invite to you our developers group.

crazywoola
crazywoola previously approved these changes Feb 7, 2024
@dosubot dosubot bot added the lgtm label Feb 7, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here we're using app.config.get('xxx') to get configuration variables, but it seems like there's no logic declared in config.py to fetch the environment variables?

@dosubot dosubot bot removed the lgtm label Feb 7, 2024
@jonahcui
Copy link
Contributor Author

jonahcui commented Feb 7, 2024

So here we're using app.config.get('xxx') to get configuration variables, but it seems like there's no logic declared in config.py to fetch the environment variables?

Thank u, I changed the config.py and submitted it.

Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 😊
BTW, would it be possible for you to help us add some explanations about these environment variables in the documentation (both in English and Chinese)? We would really appreciate it. 🙏
https://github.com/langgenius/dify-docs/blob/main/en/getting-started/install-self-hosted/environments.md#mail-related-configuration
https://github.com/langgenius/dify-docs/blob/main/zh_CN/getting-started/install-self-hosted/environments.md#%E9%82%AE%E4%BB%B6%E7%9B%B8%E5%85%B3%E9%85%8D%E7%BD%AE

@dosubot dosubot bot added the lgtm label Feb 7, 2024
@crazywoola crazywoola merged commit 71e5828 into langgenius:main Feb 7, 2024
4 checks passed
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants