Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 0.5.3 #2306

Merged
merged 3 commits into from
Feb 1, 2024
Merged

bump version to 0.5.3 #2306

merged 3 commits into from
Feb 1, 2024

Conversation

takatost
Copy link
Collaborator

@takatost takatost commented Jan 31, 2024

version to 0.5.3 and reformat python imports

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 31, 2024
@takatost takatost added this to the v0.5.3 milestone Jan 31, 2024
crazywoola
crazywoola previously approved these changes Jan 31, 2024
@dosubot dosubot bot added the lgtm label Jan 31, 2024
@bowenliang123
Copy link
Contributor

Would you like to consider applying dev/reformat to python import styling before the release ofevery version?
This would be great for rebasing our self-hosted repos. Thanks.
@takatost

@takatost
Copy link
Collaborator Author

Would you like to consider applying dev/reformat to python import styling before the release ofevery version? This would be great for rebasing our self-hosted repos. Thanks. @takatost

What action should I take?

@takatost
Copy link
Collaborator Author

Would you like to consider applying dev/reformat to python import styling before the release ofevery version? This would be great for rebasing our self-hosted repos. Thanks. @takatost

BTW, this operation is quite a breaking change for many of us developers and contributors. When merging the reformatted version, we'll need to resolve a lot of conflicts. Is there a more elegant solution?

@bowenliang123
Copy link
Contributor

We use the style check test and the reformat tools together, which leads to a good practice in Apache Kyuubi.
The key point is that both approaches should be brought to stable outputs. And the lining tools should provide a one-key reformatting solution. The dev/reformat does so.

@bowenliang123
Copy link
Contributor

What action should I take?

It's an optional suggestion anyway. We could apply the dev/reformat script and commit the changes in a new PR before cutting the branch for bumping to 0.5.3.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 1, 2024
@takatost takatost merged commit 9f637ea into main Feb 1, 2024
6 checks passed
@takatost takatost deleted the feat/bump-0-5-3 branch February 1, 2024 10:11
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants