-
Notifications
You must be signed in to change notification settings - Fork 17.2k
chore: add script for running mypy type checks and speed up mypy checks in CI jobs #17489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
12bebe5
to
076431d
Compare
cc @laipz8200 |
27ee6e8
to
bc5dde5
Compare
if you remove stubs from the lock file, they will be removed when you run poetry sync. |
With the latest dev script to rerun the mypy checks, all the required stub dependencies will be automately installed again from pip cache, which takes very little time. It's also worth to pay attention is that currently pinned sub versions in pyproject.toml and the Poetry lockfile are not fully satisfied for mypy checks, and there still requires auto installing in testing runtime. |
Or shall I leave the stub versions pinned, and only adding the script to run mypy checks? I'll follow your advice. |
Hi @laipz8200 , after the offline disscussion with you, I have completed these changes:
And the time cost of the repeated mypy checks in CI workflow has been shrinked down to 3-5 seconds, with stub files installed and properly cached mypy files. |
61a8704
to
375f043
Compare
* commit '2c2efe2e1e46751206dfa5972790cef6ad31a93f': (169 commits) chore(*): bump version to 1.2.0 (langgenius#17675) feat(graph_engine): yield control to other threads before node run. (langgenius#17689) chore: find code with high complexity (langgenius#17679) Chore: remove beta tag of app type (langgenius#17676) fix: Account.query => db.session.query(Account) (langgenius#17667) feat: add plugin daemon oss env config (langgenius#17663) chore: add script for running mypy type checks and speed up mypy checks in CI jobs (langgenius#17489) optimize: docker-compose.middleware.yaml update env_file dependence (langgenius#17646) chore: add `'no-empty-function': 'error'` to `eslint.config.mjs` (langgenius#17656) Fix Performance Issues: (langgenius#17083) Accelerate migration (langgenius#17088) chore: bump Nodejs in web image from 20 to 22 LTS (langgenius#13341) Fixed the model-modal titles not being clearly distinguished between "Add" and "Setup" (langgenius#17634) feat: enhance index type handling and add error notification for missing embedding model (langgenius#16836) chore: bump pnpm to v10 in web dockerfile (langgenius#17611) chore: add unit test to high frequency hooks (langgenius#17617) fix(transport): add missing verify parameter to httpx.HTTPTransport (langgenius#17612) fix: Sass @import warning (langgenius#17604) fix: Extract docx file fails when the file contains an invalid link (langgenius#17576) fix: segment keywords bug (langgenius#17599) ... # Conflicts: # api/poetry.lock
Summary
dev/run-mypy
for running mypy type checkstypes-*
as required by mypyScreenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods