Fix the issue where TextGeneration component does not correctly clear input data.
#12351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
crazywoola
approved these changes
Jan 4, 2025
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Jan 11, 2025
* commit 'c236f05f4b575884b42fc45819ad71b05a22115c': (135 commits) chore: bump version to 0.15.0 (langgenius#12297) refactor: enhance API token validation with session locking and last used timestamp update (langgenius#12426) Fix newline characters in tables during document parsing (langgenius#12112) fix:deepseek tool call not working correctly (langgenius#12437) add fish-speech-1.5 from siliconflow (langgenius#12425) chore(docker/.env.example): Add TOP_K_MAX_VALUE to the `.env.example`… (langgenius#12422) refactor: use tiktoken for token calculation (langgenius#12416) fix: [PromptEditorHeightResizeWrap] Bug langgenius#12410 (langgenius#12406) Fixes langgenius#12414: Add cheaper model and long context model for Qwen2.5-72B-Instruct from siliconflow (langgenius#12415) Support TTS and Speech2Text for Model Provider GPUStack (langgenius#12381) mark deprecated models in siliconflow langgenius#12399 (langgenius#12405) fix: http method can be upper case and lower case close langgenius#11877 (langgenius#12401) fix: enhance chunk list management with new invalidation keys and imp… (langgenius#12396) [Fix] revert sagemaker llm to support model hub (langgenius#12378) sandbox doesn't provide auto disable log (langgenius#12388) feat: support config top max value by env (langgenius#12375) chore: chat app textarea auto focus (langgenius#12366) feat: support configuration of refresh token expiration by environment variable (langgenius#12335) fix: resolve issue with the opening statement generated by the `AutomaticRes` component failing to sync between states. (langgenius#12349) Fix the issue where `TextGeneration` component does not correctly clear input data. (langgenius#12351) ... # Conflicts: # api/core/helper/code_executor/code_executor.py # api/poetry.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #11849
This PR is a resubmission as requested, as part of the now-closed #11850 .
Fixed
TextGenerationcomponent does not correctly clear input dataTextGenerationcomponent did not properly reset references when clearing the form. This issue caused old form values to be automatically filled in upon re-entering data. Now, the form references are correctly reset after clearing, ensuring that new input data is not affected by previous values.Modification Details
This pull request includes changes to the
web/app/components/share/text-generation/index.tsxfile to improve the handling of state updates and references. The most important changes are the addition of theuseCallbackhook and the refactoring of theinputsstate management.Improvements to state management:
useCallbackto memoize thesetInputsfunction, ensuring that it does not get recreated on each render. (web/app/components/share/text-generation/index.tsx)inputsstate management by introducingdoSetInputsandinputsRefto keep the state and its reference in sync. (web/app/components/share/text-generation/index.tsx)Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods