Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue #10596 by making the iteration node outputs right #11394

Merged
merged 5 commits into from
Dec 7, 2024
Merged

fix: issue #10596 by making the iteration node outputs right #11394

merged 5 commits into from
Dec 7, 2024

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 5, 2024 •
edited
Loading

Summary

fix: issue #10596 by making iteration node outputs right

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@yihong0618
fix: issue langgenius#10596 by cast ArrayObjectVariable to ArrayFileS…
3079a35 
…egment when node are files outputs

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 5, 2024
@crazywoola crazywoola requested a review from laipz8200 December 5, 2024 12:34
@laipz8200
Copy link
Member

This issue occurs by the Iteration node, let's fix it in the Iteration node.

@laipz8200
feat: allow to output File instance directly in Iteration node
ea12317 
Signed-off-by: -LAN- <laipz8200@outlook.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 6, 2024
laipz8200
laipz8200 previously approved these changes Dec 6, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2024
@laipz8200
Copy link
Member

The tests seem to be stuck in an infinite loop, will check it later

@yihong0618
fix: para run iter node is wrong args and and empty check to ignore f…
172db78 
…orever loop

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

The tests seem to be stuck in an infinite loop, will check it later

nice tests to avoid this~

@yihong0618 yihong0618 changed the title fix: issue #10596 by cast ArrayObjectVariable to ArrayFileSegment fix: issue #10596 by making the iteration node outputs dight Dec 7, 2024
@yihong0618 yihong0618 changed the title fix: issue #10596 by making the iteration node outputs dight fix: issue #10596 by making the iteration node outputs right Dec 7, 2024
@yihong0618
fix: typing
5a5c845 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
fix: drop Empty break by discuss
ed48c0f 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
laipz8200
laipz8200 approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A huge thanks to you!

@laipz8200 laipz8200 merged commit d9d5d35 into langgenius:main Dec 7, 2024
5 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
@yihong0618 @laipz8200 @iamjoel
fix: issue #10596 by making the iteration node outputs right (#11394)
24d43dc 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: -LAN- <laipz8200@outlook.com>
Co-authored-by: -LAN- <laipz8200@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihong0618 @laipz8200