Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http node download file always image type #11319

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: http node download file always image type #11319

merged 2 commits into from
Dec 4, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Dec 4, 2024

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
be7d2255a11c4a6dee81e838121b25c 07fcf377215a28758b42344dcb646e2

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 4, 2024
@crazywoola crazywoola requested a review from laipz8200 December 4, 2024 02:56
laipz8200
laipz8200 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laipz8200 laipz8200 merged commit d470e55 into langgenius:main Dec 4, 2024
5 checks passed
@laipz8200 laipz8200 mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjlarry @laipz8200 @crazywoola