Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tool parameters parsing compatible with the response of glm4 model in xinference provider when function tool call integerated #11049

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

cyflhn
Copy link
Contributor

@cyflhn cyflhn commented Nov 25, 2024

Summary

As the response of glm4 model for function calling is a little bit weird, the parameters for function tool is returned as a string format, not dictionary format. So there will be an error raised when handling tool parameter parsing.

Close#11048

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Nov 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 25, 2024
@crazywoola crazywoola merged commit 87c831e into langgenius:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants