Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: update icon and Divider components #10975

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

douxc
Copy link
Contributor

@douxc douxc commented Nov 22, 2024

Summary

update remix icon to 4.5.0
update themes css variables
use cva to handle Divider component styles, allowing adjustments with className

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. dependencies Pull requests that update a dependency file 📚 documentation Improvements or additions to documentation labels Nov 22, 2024
@douxc douxc changed the title Feat: update icon and divider Feat: update icon and Divider components Nov 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2024
@douxc douxc merged commit 8a83edc into main Nov 22, 2024
7 checks passed
@douxc douxc deleted the feat/update-icon-and-divider branch November 22, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants