Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support optional query content #1097

Merged
merged 29 commits into from
Sep 9, 2023

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Sep 4, 2023

⚠️ [BREAKING CHANGE] ⚠️

  • The fixed parameters of the Query content in the text generation application have been removed. Users can freely add any variables in the prompt, instead of appending the content of the query content at the end.
  • The query parameter in the POST /v1/completion-messages endpoint of the App OpenAPI is expected to be completely removed in 3 months. Currently, it's optional and the parameter in API documentation has already been removed.

To ensure that the previous applications can still function properly after removing the fixed parameters in the query content of the text generation application, we need to execute a command to fix the data:

Migration Guide

  1. Enter the Docker Container: Before running the migration script, you need to enter the Docker container where your application is running. Use the following command:

    docker exec -it docker-api-1 bash
  2. Run the Migration Script: Once inside the container, execute the following migration command. The migration script can be executed multiple times without side effects:

    # --batch-size: Specifies the number of records migrated per batch, default is 500
    flask update_app_model_configs --batch-size=500

@iamjoel iamjoel changed the title feat: support optional query content2 feat: support optional query content Sep 4, 2023
@iamjoel iamjoel marked this pull request as draft September 4, 2023 03:14
crazywoola
crazywoola previously approved these changes Sep 5, 2023
@GarfieldDai GarfieldDai force-pushed the feat/generation-support-optional-query-content2 branch from d95d428 to 2ae1e58 Compare September 8, 2023 10:42
@GarfieldDai GarfieldDai force-pushed the feat/generation-support-optional-query-content2 branch from 2ae1e58 to 737bf61 Compare September 8, 2023 13:19
@iamjoel iamjoel marked this pull request as ready for review September 9, 2023 12:47
@takatost takatost merged commit 2d5ad0d into main Sep 9, 2023
@takatost takatost deleted the feat/generation-support-optional-query-content2 branch September 9, 2023 16:12
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Co-authored-by: Garfield Dai <dai.hai@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants